From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.haj.ipfire.org (localhost [IPv6:::1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4cXZk04601z2xph for ; Thu, 25 Sep 2025 13:46:00 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [IPv6:2001:678:b28::25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail01.haj.ipfire.org", Issuer "R13" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4cXZjx16n4z2xM3 for ; Thu, 25 Sep 2025 13:45:57 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4cXZjv6P9Qz19M for ; Thu, 25 Sep 2025 13:45:55 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1758807955; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SGY7E3p6bPm7CVXJ0mSWFaaxpJQpXXS//miXZnvZy8Q=; b=DfghM4s51lA1CCF9nQGM0Ukcg/l91jVXuHtw6AYkDlm3LRw/FWj/gJV7aRZEttoGauAJyE HRfdIUm2gikhlLDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1758807955; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SGY7E3p6bPm7CVXJ0mSWFaaxpJQpXXS//miXZnvZy8Q=; b=hA/H4EeLljxK8m6p5+S8NxxMUl86PRBQEEItmOhdU430W6AaRDedSZvL+JLCCF6XYZUd6k 5qnkg4Tyr3UAL4zajpJnQ3OiqOt62pzdBspbTmDYXL9ZKu888c0gAlY/TaaTaYNGkZt+/1 wdCFEuASNVuT8rs7rAobwlntSQKoipdrjss6MOQJTEXL+PH6qnRFvGuqQgbEUNlV0VncV+ bvz9vxGzgNWHwuNMq40U+YGDVw1STha6OJyWusstEkroGfEbNIArhWSgJ61xhTn7HmtyuH MQUEQlCtQJAcEMkBasdl2B/uHPDZJHXQ2bCQQT7JYu/c6eQarfaIdFBqxWZHGg== Message-ID: Date: Thu, 25 Sep 2025 15:45:54 +0200 Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: MIME-Version: 1.0 Subject: Re: [PATCH 07/16] time.cgi: Fixes bug 13883 To: development@lists.ipfire.org References: <20250925111252.11893-1-adolf.belka@ipfire.org> <20250925111252.11893-7-adolf.belka@ipfire.org> Content-Language: en-GB From: Bernhard Bitsch In-Reply-To: <20250925111252.11893-7-adolf.belka@ipfire.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reviewed-by: Bernhard Bitsch Am 25.09.2025 um 13:12 schrieb Adolf Belka: > Fixes: bug 13883 - time.cgi UPDATE_VALUE Stored Cross-Site Scripting > Signed-off-by: Adolf Belka > --- > html/cgi-bin/time.cgi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/html/cgi-bin/time.cgi b/html/cgi-bin/time.cgi > index 04c1e771f..d465354bb 100644 > --- a/html/cgi-bin/time.cgi > +++ b/html/cgi-bin/time.cgi > @@ -2,7 +2,7 @@ > ############################################################################### > # # > # IPFire.org - A linux based firewall # > -# Copyright (C) 2010 IPFire Team # > +# Copyright (C) 2010-2025 IPFire Team # > # # > # This program is free software: you can redistribute it and/or modify # > # it under the terms of the GNU General Public License as published by # > @@ -78,6 +78,7 @@ if ($timesettings{'ACTION'} eq $Lang::tr{'save'}) > if (!($timesettings{'UPDATE_VALUE'} =~ /^\d+$/) || $timesettings{'UPDATE_VALUE'} <= 0) > { > $errormessage = $Lang::tr{'invalid time period'}; > + $timesettings{'UPDATE_VALUE'} = 0; > goto ERROR; > } >