From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel =?utf-8?q?Weism=C3=BCller?= <daniel.weismueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] Core 152: the script "network-hotplug-bridges" now reads
 the variable ${ZONE}_STP from /var/ipfire/ethernet/settings so that STP can
 be turned on and off for each bridge
Date: Fri, 20 Nov 2020 07:58:32 +0100
Message-ID: <ba5fae11-c02a-ca77-5113-abc4ae5e10db@ipfire.org>
In-Reply-To: <6126BB16-DC05-45C1-8141-8C0EEF74EEA9@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2045672185493904738=="
List-Id: <development.lists.ipfire.org>

--===============2045672185493904738==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

In my opinion it is sufficient to be able to set these parameters via=20
command line.

It should only be made sure that the settings are persitend and not=20
overwritten by a reboot or the webif.

-
Daniel

Am 19.11.2020 um 15:56 schrieb Michael Tremer:
> Hello Daniel,
>
> This patch looks good to me.
>
> I had assumed that we automatically enabled STP on all bridges, but apparen=
tly we do not.
>
> How do we process with this?
>
> I suppose it is not the most user-friendly way to ask the user to edit the =
configuration file. This either must be documented somewhere or the zoneconfi=
g.cgi script needs to be extended to allow enabling STP.
>
> Does anyone want to be able to change any STP parameters like priority or c=
ost of the ports?
>
> Best,
> -Michael
>
>> On 19 Nov 2020, at 13:18, Daniel Weism=C3=BCller <daniel.weismueller(a)ipf=
ire.org> wrote:
>>
>> Signed-off-by: Daniel Weism=C3=BCller <daniel.weismueller(a)ipfire.org>
>> ---
>> config/udev/network-hotplug-bridges | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/config/udev/network-hotplug-bridges b/config/udev/network-hot=
plug-bridges
>> index 33d6d65ba..7431377bb 100644
>> --- a/config/udev/network-hotplug-bridges
>> +++ b/config/udev/network-hotplug-bridges
>> @@ -81,6 +81,7 @@ MODE=3D"$(get_value "${ZONE}_MODE")"
>>
>> # The name of the virtual bridge
>> BRIDGE=3D"$(get_value "${ZONE}_DEV")"
>> +STP=3D"$(get_value "${ZONE}_STP")"
>>
>> case "${MODE}" in
>> 	bridge)
>> @@ -89,7 +90,8 @@ case "${MODE}" in
>>
>> 		# We need to create the bridge if it doesn't exist, yet
>> 		if [ ! -d "/sys/class/net/${BRIDGE}" ]; then
>> -			ip link add "${BRIDGE}" address "${ADDRESS}" type bridge
>> +			ip link add "${BRIDGE}" address "${ADDRESS}" type bridge \
>> +				$([ "${STP}" =3D "on" ] && echo "stp_state 1")
>> 			#ip link set "${BRIDGE}" up
>> 		fi
>>
>> --=20
>> 2.28.0
>>

--===============2045672185493904738==--