From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] Remove space after every 80 characters in WebGUI
 "Logs/System Logs".
Date: Mon, 05 Aug 2024 22:40:15 +0200
Message-ID: <ba7acad3-bd79-4607-afbb-897b71d01ca9@ipfire.org>
In-Reply-To: <172288367319.1831417.3462292333355828565@mail02.haj.ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4344141804829769462=="
List-Id: <development.lists.ipfire.org>

--===============4344141804829769462==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Stephen,

On 05/08/2024 20:47, Stephen Cuka wrote:
> Hi Adolf,
>
> Thanks for your help on this.
>
> I left the original code lines in place for context.  They're not really ne=
cessary.  If it's better, I can remove them and resubmit the patch.

I think it would make more sense to remove them.

You will need to make it a v2 patch so it supersedes this one automatically i=
n patchwork.

> For the
>
> my $d =3D $2.': '.$data;
>
> suggestion, there is some special processing for the display for the RED se=
ction logs.
>
>          # correct the cut position, just when section=3DRED
>          if (($cgiparams{'SECTION'} eq 'red' ) && ($sec =3D~ /(kernel:)(.*)=
/)) {
>              $sec =3D 'kernel';
>              $data =3D $2.': '.$data;
>          }
>
> Using 'my $d =3D $2. ': ' .$data;' for everything would add the timestamp t=
o the front of the log text displayed for all sections.
>
> I'm not sure if the special processing for $data for RED is necessary.  I t=
hink that the point of the 'if' statement is to clean up the Section display =
for entries from 'kernel: ippp\d' and 'kernel: isdn.*' matches for RED, but I=
 don't know why adding the timestamp to the front of data would be desirable =
in that specific case.  I don't have any log entries to reference for that th=
ough.

I hadn't seen the special processing for the RED section logs.

I would leave it as you have done it then unless Michael or Arne or Peter com=
e back further on=C2=A0 this.

Let's keep it simple for now.

Regards,

Adolf.

>
> Thanks,
> Stephen

--===============4344141804829769462==--