From mboxrd@z Thu Jan  1 00:00:00 1970
From: Robin Roevens <robin.roevens@disroot.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] cpufrequtils: Remove SERVICES entry for this package -
 fixes Bug#12933
Date: Tue, 20 Sep 2022 22:22:46 +0200
Message-ID: <bbefc37aaddb49054b8953989d1e14a8f9f66bf0.camel@sicho.home>
In-Reply-To: <20220919145129.6714-1-adolf.belka@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7472712568947571479=="
List-Id: <development.lists.ipfire.org>

--===============7472712568947571479==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

I think you missed the install initscripts part lower in the LFS file:

	$(call INSTALL_INITSCRIPTS,$(SERVICES))

should then also be changed to 

	$(call INSTALL_INITSCRIPTS,cpufreq)

otherwise the initscript won't be installed as SERVICES is now empty.

Regards 
Robin

Adolf Belka schreef op ma 19-09-2022 om 16:51 [+0200]:
> - cpufrequtils is a set of "tools" to manage and set cpu freq
> settings.
> - There is an initscript but this is only loading the cpu dependent
> kernel modules that
>    are required by cpufrequtils.
> - Therefore cpufrequtils is not a service but a set of tools that are
> used when required.
> - SERVICES line made blank so that this addon does not show up in the
> services addon table.
> 
> Fixes: Bug#12933
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
>  lfs/cpufrequtils | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lfs/cpufrequtils b/lfs/cpufrequtils
> index 752964198..9076a70d7 100644
> --- a/lfs/cpufrequtils
> +++ b/lfs/cpufrequtils
> @@ -34,11 +34,11 @@ DL_FROM    = $(URL_IPFIRE)
>  DIR_APP    = $(DIR_SRC)/$(THISAPP)
>  TARGET     = $(DIR_INFO)/$(THISAPP)
>  PROG       = cpufrequtils
> -PAK_VER    = 11
> +PAK_VER    = 12
>  
>  DEPS       =
>  
> -SERVICES   = cpufreq
> +SERVICES   = 
>  
>  ####################################################################
> ###########
>  # Top-level Rules
> -- 
> 2.37.3
> 
> 

-- 
Dit bericht is gescanned op virussen en andere gevaarlijke
inhoud door MailScanner en lijkt schoon te zijn.


--===============7472712568947571479==--