From mboxrd@z Thu Jan  1 00:00:00 1970
From: Holger Sunke <holger.sunke@posteo.de>
To: development@lists.ipfire.org
Subject: Fwd: [PATCH 1/2] Added i586/386 support for GO language required for
 node_exporter.
Date: Fri, 07 May 2021 17:39:26 +0000
Message-ID: <bcf8ab38-337f-5204-b639-05bfa69d0b9f@posteo.de>
In-Reply-To: <23a003ef-a311-b758-7fd5-1afb6a2f6252@posteo.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6009545145886795899=="
List-Id: <development.lists.ipfire.org>

--===============6009545145886795899==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable



Am 06.05.21 um 22:26 schrieb Adolf Belka:
> Hi Holger,
>=20
> On 06/05/2021 21:46, Holger Sunke wrote:
>> ---
>> =C2=A0 lfs/Config | 4 ++++
>> =C2=A0 lfs/go=C2=A0=C2=A0=C2=A0=C2=A0 | 6 +++---
>> =C2=A0 2 files changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/lfs/Config b/lfs/Config
>> index eadbbc408..4d0f2f00b 100644
>> --- a/lfs/Config
>> +++ b/lfs/Config
>> @@ -138,6 +138,10 @@ ifeq "$(BUILD_ARCH)" "aarch64"
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 GOARCH =3D arm64
>> =C2=A0 endif
>> +ifeq "$(BUILD_ARCH)" "i586"
>> +=C2=A0=C2=A0=C2=A0 GOARCH =3D 386
>> +endif
>> +
>=20
> A question I would have here is if creating this package in i586=20
> architecture makes sense when in 7 months the i586 version of IPFire=20
> will have reached End Of Life and will no longer be updated.
>=20
> Regards,
>=20
> Adolf

I now remember having red about this but I forgot that fact and I even=20
believed my device is a 32bit one. Luckily it is x86_64 ...
So on the one hand we can drop this, or expand support for all=20
architecutres supported by ipfire now and in the longer future.

Kind regards

Holger

>=20
>>  =20
>> ##########################################################################=
#####=20
>>
>> =C2=A0 # Common Macro Definitions
>>  =20
>> ##########################################################################=
#####=20
>>
>> diff --git a/lfs/go b/lfs/go
>> index 6ebb37080..97effcb84 100644
>> --- a/lfs/go
>> +++ b/lfs/go
>> @@ -28,10 +28,9 @@ VER=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =3D 1.15.4
>> =C2=A0 THISAPP=C2=A0=C2=A0=C2=A0 =3D go-$(VER)
>> =C2=A0 DL_FILE=C2=A0=C2=A0=C2=A0 =3D go$(VER).$(GOOS)-$(GOARCH).tar.gz
>> -DL_FROM=C2=A0=C2=A0=C2=A0 =3D $(URL_IPFIRE)
>> +DL_FROM=C2=A0=C2=A0=C2=A0 =3D https://golang.org/dl/
>> =C2=A0 DIR_APP=C2=A0=C2=A0=C2=A0 =3D $(DIR_SRC)/go
>> =C2=A0 TARGET=C2=A0=C2=A0=C2=A0=C2=A0 =3D $(DIR_INFO)/$(THISAPP)
>> -SUP_ARCH=C2=A0=C2=A0 =3D x86_64
>>  =20
>> ##########################################################################=
#####=20
>>
>> =C2=A0 # Top-level Rules
>> @@ -41,7 +40,8 @@ objects =3D $(DL_FILE)
>> =C2=A0 $(DL_FILE) =3D $(DL_FROM)/$(DL_FILE)
>> -$(DL_FILE)_MD5 =3D 8e9d11a16f03372c82c5134278a0bd7d
>> +go$(VER).$(GOOS)-amd64.tar.gz_MD5 =3D 8e9d11a16f03372c82c5134278a0bd7d
>> +go$(VER).$(GOOS)-386.tar.gz_MD5 =3D 8d1c3539c88710273f61b0c810b7448c
>> =C2=A0 install : $(TARGET)

--===============6009545145886795899==--