Fwd: [PATCH 1/2] Added i586/386 support for GO language required for node_exporter.

Fwd: [PATCH 1/2] Added i586/386 support for GO language required for node_exporter.

[Holger Sunke]

[-- Attachment #1: Type: text/plain, Size: 2164 bytes --]



Am 06.05.21 um 22:26 schrieb Adolf Belka:
> Hi Holger,
> 
> On 06/05/2021 21:46, Holger Sunke wrote:
>> ---
>>   lfs/Config | 4 ++++
>>   lfs/go     | 6 +++---
>>   2 files changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/lfs/Config b/lfs/Config
>> index eadbbc408..4d0f2f00b 100644
>> --- a/lfs/Config
>> +++ b/lfs/Config
>> @@ -138,6 +138,10 @@ ifeq "$(BUILD_ARCH)" "aarch64"
>>       GOARCH = arm64
>>   endif
>> +ifeq "$(BUILD_ARCH)" "i586"
>> +    GOARCH = 386
>> +endif
>> +
> 
> A question I would have here is if creating this package in i586 
> architecture makes sense when in 7 months the i586 version of IPFire 
> will have reached End Of Life and will no longer be updated.
> 
> Regards,
> 
> Adolf

I now remember having red about this but I forgot that fact and I even 
believed my device is a 32bit one. Luckily it is x86_64 ...
So on the one hand we can drop this, or expand support for all 
architecutres supported by ipfire now and in the longer future.

Kind regards

Holger

> 
>>   
>> ############################################################################### 
>>
>>   # Common Macro Definitions
>>   
>> ############################################################################### 
>>
>> diff --git a/lfs/go b/lfs/go
>> index 6ebb37080..97effcb84 100644
>> --- a/lfs/go
>> +++ b/lfs/go
>> @@ -28,10 +28,9 @@ VER        = 1.15.4
>>   THISAPP    = go-$(VER)
>>   DL_FILE    = go$(VER).$(GOOS)-$(GOARCH).tar.gz
>> -DL_FROM    = $(URL_IPFIRE)
>> +DL_FROM    = https://golang.org/dl/
>>   DIR_APP    = $(DIR_SRC)/go
>>   TARGET     = $(DIR_INFO)/$(THISAPP)
>> -SUP_ARCH   = x86_64
>>   
>> ############################################################################### 
>>
>>   # Top-level Rules
>> @@ -41,7 +40,8 @@ objects = $(DL_FILE)
>>   $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
>> -$(DL_FILE)_MD5 = 8e9d11a16f03372c82c5134278a0bd7d
>> +go$(VER).$(GOOS)-amd64.tar.gz_MD5 = 8e9d11a16f03372c82c5134278a0bd7d
>> +go$(VER).$(GOOS)-386.tar.gz_MD5 = 8d1c3539c88710273f61b0c810b7448c
>>   install : $(TARGET)