From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter =?utf-8?q?M=C3=BCller?= To: development@lists.ipfire.org Subject: Re: Helo command rejected: Invalid name Date: Mon, 23 Sep 2024 20:11:33 +0000 Message-ID: In-Reply-To: <1be0bd8d-d774-48eb-80ad-17578a145308@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6028926325724389479==" List-Id: --===============6028926325724389479== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Hello Matthias, thank you for your reply. On 2024-09-23 19:13, Matthias Fischer wrote: > Hi, > > ok, two dots then... Hm. > > I saw them and feared it would be something like that. > > But I found a solution: > > ***SNIP*** > git send-email --annotate --smtp-domain=devel64-2.localdomain -1 > ***SNAP*** > > This command worked - I added the "--smtp-domain=". ;-) Worked perfectly fine indeed. I just reviewed the Squid patch. :-) My suspicion is that Git tries to cobble together its HELO FQDN from the system's bare hostname, followed by a dot, the network FQDN (i. e., the search domain), and a trailing dot. If there is no search domain configured, or the DHCP server did not pass one to the client, Git ends up sending an RFC-ignorant HELO FQDN. I'd expect that far more Git users encounter this bug. More and more postmasters reject messages violating RFCs during the envelope phase - including submission channels for authenticated users. God knows how broken the rest of such e-mails is if the MUA cannot even get the SMTP envelope phase right... :-) Anyway, glad to have this sorted. Please do not hesitate to raise any other quirks with our infrastructure, if you encounter any. All the best, Peter Müller > > Best > Matthias > > On 23.09.2024 19:01, Peter Müller wrote: >> Hello Matthias, >> >> thank you for raising this. >> >> On 2024-09-23 16:54, Michael Tremer wrote: >>> Hello Matthias, >>> >>> I let Peter know. He will get back to you. >>> >>> -Michael >>> >>>> On 23 Sep 2024, at 17:07, Matthias Fischer >>>> wrote: >>>> >>>> Hi, >>>> >>>> I'm giving up. >>>> >>>> No matter what name I use (Devel-2, Devel, Justaname, Nothing), from >>>> one >>>> day to another I can't send git mails anymore: >> >> This is because for whatever reason your local application chose >> to submit an invalid HELO/EHLO banner when establishing the SMTP >> connection to our mail infrastructure. >> >> The culprit is the double dot ("devel.."), which should not be >> there. This might have been caused by an update on your end, or >> your machine having set a hostname only, rather than a complete >> FQDN (and Git not coping with that properly). >> >> If it takes longer to fix this, turning off HELO validation is an >> option, though I have to admit I am not really fond of that, >> especially >> not since it has been in place for years, and nothing has changed >> on this end. :-) >> >> Thanks, and best regards, >> Peter Müller >> >>>> >>>> ***SNIP*** >>>> root(a)Devel64-2: /git/ipfire-2.x # git send-email --annotate -1 >>>> /tmp/Zp2mVJvp60/0001-squid-Update-to-6.11.patch >>>> Password for 'smtp://mfischer(a)submissions.ipfire.org:465': >>>> 5.5.2 : Helo command rejected: Invalid name. Refer to >>>> https://wiki.ipfire.org/postmaster for further information. >>>> >>>> root(a)Devel64-2: /git/ipfire-2.x # hostname Justaname >>>> >>>> root(a)Devel64-2: /git/ipfire-2.x # git send-email --annotate -1 >>>> /tmp/XKUXVyPmdy/0001-squid-Update-to-6.11.patch >>>> Password for 'smtp://mfischer(a)submissions.ipfire.org:465': >>>> 5.5.2 : Helo command rejected: Invalid name. Refer to >>>> https://wiki.ipfire.org/postmaster for further information. >>>> >>>> root(a)Devel64-2: /git/ipfire-2.x # hostname >>>> Justaname >>>> >>>> root(a)Devel64-2: /git/ipfire-2.x # hostname Nothing >>>> >>>> root(a)Devel64-2: /git/ipfire-2.x # git send-email --annotate -1 >>>> /tmp/yRTXjA1gp9/0001-squid-Update-to-6.11.patch >>>> Password for 'smtp://mfischer(a)submissions.ipfire.org:465': >>>> 5.5.2 : Helo command rejected: Invalid name. Refer to >>>> https://wiki.ipfire.org/postmaster for further information. >>>> ***SNAP*** >>>> >>>> If the "postmaster" would have an idea, I'd be thankful... >>>> >>>> Best >>>> Matthias >>>> --===============6028926325724389479==--