Re: [PATCH 1/3] rrdimage: Add scripts for new graph display method

[Leo Hofmann <hofmann@leo-andres.de>]

[-- Attachment #1: Type: text/plain, Size: 961 bytes --]

Hi all,

this series of patches is a follow-up to this discussion: https://lists.ipfire.org/pipermail/development/2021-March/009523.html

I decided to write a new CGI which handles the graph image generation (png). This allowed me to add new features and remove a lot of uneccessary parameter handling from the other CGIs.
I think this is in presentable form now. But there are still some issues I'd like to hear your opinion on:

- Because I have collected all the graph functions from the CGIs, there is now a very long if-elseif chain in getrrdimage.cgi. I tried my best to keep this as readable as possible. But I'd be happy to rewrite that if someone knows a better method.

- My test system doesn't have any hardware sensors or IPsec connections. I'm pretty sure that these graphs work but I can't test them.

- getrrdimage.cgi redirects graphs it can't generate to ensure compatibility with addons. Is that necessary?

Happy holidays!
Leo