From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Hofmann To: development@lists.ipfire.org Subject: Re: [PATCH 1/3] rrdimage: Add scripts for new graph display method Date: Thu, 01 Apr 2021 15:36:44 +0200 Message-ID: In-Reply-To: <20210401133516.1058-1-hofmann@leo-andres.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6667034812275612583==" List-Id: --===============6667034812275612583== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi all, this series of patches is a follow-up to this discussion: https://lists.ipfir= e.org/pipermail/development/2021-March/009523.html I decided to write a new CGI which handles the graph image generation (png). = This allowed me to add new features and remove a lot of uneccessary parameter= handling from the other CGIs. I think this is in presentable form now. But there are still some issues I'd = like to hear your opinion on: - Because I have collected all the graph functions from the CGIs, there is no= w a very long if-elseif chain in getrrdimage.cgi. I tried my best to keep thi= s as readable as possible. But I'd be happy to rewrite that if someone knows = a better method. - My test system doesn't have any hardware sensors or IPsec connections. I'm = pretty sure that these graphs work but I can't test them. - getrrdimage.cgi redirects graphs it can't generate to ensure compatibility = with addons. Is that necessary? Happy holidays! Leo --===============6667034812275612583==--