public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 1/2] log.dat: Fix bug13762 - ssh logins not shown in system logs
Date: Thu, 29 Aug 2024 11:28:44 +0200	[thread overview]
Message-ID: <bf76c64f-4cd5-4ff2-bd31-9febea956043@ipfire.org> (raw)
In-Reply-To: <20240828100446.6617-1-adolf.belka@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1588 bytes --]

Tested-by: Bernhard Bitsch <bbitsch(a)ipfire.org>
Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>

Am 28.08.2024 um 12:04 schrieb Adolf Belka:
> - With the update of openssh to version 9.8 in CU187 the daemon was changed from sshd to
>     sshd-session. Therefore the log.dat no longer finds any info related to the logins.
> - This updates the section regex to look for both sshd and sshd-session.
> - Tested out on my vm system and confirmed to work.
> - This fix will make available all previous log info for sshd-session in the messages log
>     as it continued to be stored, just could not be read by the WUI system log.
> 
> Fixes: bug13762
> Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
>   html/cgi-bin/logs.cgi/log.dat | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/html/cgi-bin/logs.cgi/log.dat b/html/cgi-bin/logs.cgi/log.dat
> index 01c382a0d..41f81e99d 100644
> --- a/html/cgi-bin/logs.cgi/log.dat
> +++ b/html/cgi-bin/logs.cgi/log.dat
> @@ -75,7 +75,7 @@ my %sections = (
>           'samba' => '(nmbd|smbd|winbind)\[\d+\]:',
>           'suricata' => '(suricata: )',
>           'squid' => '(squid\[.*\]: |squid: )',
> -        'ssh' => '(sshd(?:\(.*\))?\[.*\]: )',
> +        'ssh' => '(sshd(?:\(.*\))?\[.*\]: |sshd-session(?:\(.*\))?\[.*\]:)',
>           'unbound' => '(unbound: \[.*?\])(.*:.*$)',
>           'urlfilter bl' => '(installpackage\[urlfilter\]: )',
>           'wireless' => '(hostapd:|kernel: ath.*:|kernel: wifi[0-9]:)',


      parent reply	other threads:[~2024-08-29  9:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-28 10:04 Adolf Belka
2024-08-28 10:04 ` [PATCH 2/2] logwatch: Fixes bug13762 - ssh logins not shown on Log Summary page Adolf Belka
2024-08-29  9:28 ` Bernhard Bitsch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf76c64f-4cd5-4ff2-bd31-9febea956043@ipfire.org \
    --to=bbitsch@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox