From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter =?utf-8?q?M=C3=BCller?= <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] tftpd: add missing directory
Date: Sun, 24 Jul 2022 12:52:41 +0000
Message-ID: <bfa7325a-57ee-a01d-f02a-2d44f0321ea4@ipfire.org>
In-Reply-To: <20220723161408.3370724-1-jon.murphy@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7544796802878134887=="
List-Id: <development.lists.ipfire.org>

--===============7544796802878134887==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Jon,

thank you for submitting this.

Just a quick question: With regards to the tftpd rootfile (which currently do=
es not
include /var/tftpboot), isn't this change necessary during installation of th=
e add-on
(as well)? I. e., shouldn't this go into the installation script of the add-o=
n?

Or did I got this wrong?

Thanks, and best regards,
Peter M=C3=BCller


>   - starting tftpd currently throws "missing directory" error
>   - this change corrects the issue
>=20
> Signed-off-by: Jon Murphy <jon.murphy(a)ipfire.org>
> ---
>   lfs/tftpd | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>=20
> diff --git a/lfs/tftpd b/lfs/tftpd
> index cb3d03415..f441c499c 100644
> --- a/lfs/tftpd
> +++ b/lfs/tftpd
> @@ -1,7 +1,7 @@
>   #########################################################################=
######
>   #                                                                        =
     #
>   # IPFire.org - A linux based firewall                                    =
     #
> -# Copyright (C) 2007-2021  IPFire Team  <info(a)ipfire.org>               =
      #
> +# Copyright (C) 2007-2022  IPFire Team  <info(a)ipfire.org>               =
      #
>   #                                                                        =
     #
>   # This program is free software: you can redistribute it and/or modify   =
     #
>   # it under the terms of the GNU General Public License as published by   =
     #
> @@ -34,7 +34,7 @@ DL_FROM    =3D $(URL_IPFIRE)
>   DIR_APP    =3D $(DIR_SRC)/$(THISAPP)
>   TARGET     =3D $(DIR_INFO)/$(THISAPP)
>   PROG       =3D tftpd
> -PAK_VER    =3D 2
> +PAK_VER    =3D 3
>  =20
>   DEPS       =3D
>  =20
> @@ -87,6 +87,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
>   	cd $(DIR_APP) && make $(MAKETUNING)
>   	cd $(DIR_APP) && make install
>   	mv -fv /usr/sbin/in.tftpd /usr/sbin/tftpd
> +	mkdir -pv /var/tftpboot
>   	#install initscripts
>   	$(call INSTALL_INITSCRIPTS,$(SERVICES))
>   	@rm -rf $(DIR_APP)

--===============7544796802878134887==--