From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Krieger To: development@lists.ipfire.org Subject: Re: [PATCH] ddns: Add provider Feste-IP.Net Date: Sat, 08 May 2021 12:20:15 +0000 Message-ID: In-Reply-To: <2D0B50FE-BFA0-42E4-9B61-AE122E268A90@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3672514717860252216==" List-Id: --===============3672514717860252216== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello Michael, unfortunately my actual Python knowledge is very basic. I found no=20 solution to implement ipv6 in addition to ipv4. Also IPFire is based on=20 ipv4 and will be there in future as far as I understood. I adapted providers.py to force FesteIP.Net to use ipv4 according to the=20 information on the homepage. A test showed no issue: ddns -d update --force ipfire.feste-ip.net Running on distribution: ipfire-2 Loading configuration file /var/ipfire/ddns/ddns.conf Updating ipfire.feste-ip.net forced Sending request (GET):=20 https://v4.members.feste-ip.net/nic/update/?hostname=3Dipfire.feste-ip.net&my= ip=3D5.63.50.246 Request header: Authorization: Basic MjA2MDA0Ol84UnN2bjZidDk=3D User-agent: IPFireDDNSUpdater/013 Pragma: no-cache Response header (Status Code 200): Date: Sat, 08 May 2021 12:01:04 GMT Content-Type: text/plain Connection: close Accept-Ranges: none Server: Feste-IP.net Server Strict-Transport-Security: max-age=3D15768000 Dynamic DNS update for ipfire.feste-ip.net (Feste-IP.Net) successful Logging successful update for ipfire.feste-ip.net Opening database /var/lib/ddns.db So, from my point of view the patch should do the job. Regards, Martin Krieger diff --git a/README b/README index b6decb3..fa6ce5e 100644 --- a/README +++ b/README @@ -68,6 +68,7 @@ SUPPORTED PROVIDERS: easydns.com enom.com entrydns.net + feste-ip.net freedns.afraid.org inwx.com|de|at|ch|es itsdns.de diff --git a/src/ddns/providers.py b/src/ddns/providers.py index 56e6620..8348ed1 100644 --- a/src/ddns/providers.py +++ b/src/ddns/providers.py @@ -1178,6 +1178,17 @@ class DDNSProviderEntryDNS(DDNSProvider): # If we got here, some other update error happened. raise DDNSUpdateError +class DDNSProviderFesteIPNet(DDNSProtocolDynDNS2, DDNSProvider): + handle =3D "feste-ip.net" + name =3D "Feste-IP.Net" + website =3D "https://www.feste-ip.net/" + protocols =3D ("ipv4",) + + # Information about the format of the request is to be found + # https://www.feste-ip.net/ddns-service/einrichtung/linux/ + # https://www.feste-ip.net/ddns-service/einrichtung/ipv4-ipv6/ + + url =3D "https://v4.members.feste-ip.net/nic/update" class DDNSProviderFreeDNSAfraidOrg(DDNSProvider): handle =3D "freedns.afraid.org" Michael Tremer: > Hello Martin, >=20 >> On 6 May 2021, at 11:21, Martin Krieger wrote: >> >> Hello Michael, >> >> by eMail again, because I didn't figure out to use git (commit, format-pat= ch & send-email) in the correct way for patch submission. Sorry. >> >> Regards, >> >> Martin Krieger >> >> diff --git a/README b/README >> index b6decb3..fa6ce5e 100644 >> --- a/README >> +++ b/README >> @@ -68,6 +68,7 @@ SUPPORTED PROVIDERS: >> easydns.com >> enom.com >> entrydns.net >> + feste-ip.net >> freedns.afraid.org >> inwx.com|de|at|ch|es >> itsdns.de >> diff --git a/src/ddns/providers.py b/src/ddns/providers.py >> index 56e6620..c53ff9a 100644 >> --- a/src/ddns/providers.py >> +++ b/src/ddns/providers.py >> @@ -1178,6 +1178,16 @@ class DDNSProviderEntryDNS(DDNSProvider): >> # If we got here, some other update error happened. >> raise DDNSUpdateError >> >> +class DDNSProviderFesteIPNet(DDNSProtocolDynDNS2, DDNSProvider): >> + handle =3D "feste-ip.net" >> + name =3D "Feste-IP.Net" >> + website =3D "https://www.feste-ip.net/" >> + protocols =3D ("ipv4","ipv6") >=20 > According to the documentation, the request has to be sent to a different h= ost for IPv6. Just adding it to the list probably won=E2=80=99t work because = this provider has implemented a different way to use the DynDNS API. >=20 >> + # Information about the format of the request is to be found >> + # https://www.feste-ip.net/ddns-service/einrichtung/linux/ >> + >> + url =3D "https://members.feste-ip.net/nic/update" >> >> class DDNSProviderFreeDNSAfraidOrg(DDNSProvider): >> handle =3D "freedns.afraid.org" >> >> Michael Tremer: >>> Hello Martin, >>> Thank you very much for your submission. >>>> On 5 May 2021, at 19:13, Martin Krieger wrote: >>>> >>>> diff --git a/README b/README >>>> index b6decb3..fa6ce5e 100644 >>>> --- a/README >>>> +++ b/README >>>> @@ -68,6 +68,7 @@ SUPPORTED PROVIDERS: >>>> easydns.com >>>> enom.com >>>> entrydns.net >>>> + feste-ip.net >>>> freedns.afraid.org >>>> inwx.com|de|at|ch|es >>>> itsdns.de >>>> diff --git a/src/ddns/providers.py b/src/ddns/providers.py >>>> index 56e6620..c70423b 100644 >>>> --- a/src/ddns/providers.py >>>> +++ b/src/ddns/providers.py >>>> @@ -1178,6 +1178,16 @@ class DDNSProviderEntryDNS(DDNSProvider): >>>> # If we got here, some other update error happened. >>>> raise DDNSUpdateError >>>> >>>> +class DDNSProviderFesteIPNet(DDNSProtocolDynDNS2, DDNSProvider): >>>> + handle =3D "feste-ip.net" >>>> + name =3D "Feste-IP.Net" >>>> + website =3D "https//www.feste-ip.net/" >>> You are missing a =E2=80=9C:=E2=80=9D in the URL. >>>> + protocols =3D ("ipv4",) >>> According to this documentation, the provider supports IPv6 as well: >>> https://www.feste-ip.net/ddns-service/einrichtung/linux/ >>>> + # Information about the format of the request is to be found >>>> + # https://www.feste-ip.net/ddns-service/allgemeine-informatione= n/ >>>> + >>>> + url =3D "https://members.feste-ip.net/nic/update" >>>> >>>> class DDNSProviderFreeDNSAfraidOrg(DDNSProvider): >>>> handle =3D =E2=80=9Cfreedns.afraid.org" >>>> >>> Best, >>> -Michael >> >=20 --===============3672514717860252216== Content-Type: application/pgp-signature Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="OpenPGP_signature.sig" MIME-Version: 1.0 LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ2dBZEZpRUVuV0tqZ2ZoSXBr anh4Tm1BRWV2RUVOYVpqR01GQW1DV2dmOEFDZ2tRRWV2RUVOYVoKakdNVnN4QUFwMUZaa01ZUDBt M3Rjdld0WnhQSWc2U2hoem5obzVNeGR0YmtJTFR5SnBDN1dLcGw3cXBnR2VvTQpKeFF5N3ZRNTIz RjBBNzhkU3dxZmlnUkhXM1B3NUptM3JqMXpHRC94VFFVRnFQbkxNWnBnaHhZUXhCcVprS0xRCnVV Ym9SVUUrVHduTEFBdzFETE5kSHVCeUVOQ285UVI5dVArQ0dLV1FocVFGSmd3N2VZQk5Wek1LWDFz M2xrNjMKRjRFNkMzcUEyR245cTJnWDU3enNJaWljc1d4R0xBUzR4a0dwWUhlaEUxVjcwMUJrWFlV K1hMVStidEFiL3ZzUQpLTmpjNmhpaUdUVTk0WGN2UkJkZ2VuVWl0UHAvRUROYVFpaEYrMElRbUt3 c0FKRXFXdXRDellNU3hFM1Z3MnIzCit6SWJuc2pVMHdqUFNyajQ2WDVPcTZVS0NFWDdqUVBOVXhG M29Wa3lVaU0yN25MTHR0WEg5SzBkdnpNY3RyOHAKTUVQaTY2ZG16WWVrOVZIbUFaR1hYaWE0RU9W NzBOVzI5T25wQnM0NVpBdlRKYkVJVnY0YWJSTEppTEk3clk0NwprR2s1dlF5UDYrRkN3ZHl3R3pk WXVyYjV1aGkvdndrTWE5VExZOGwyZ3V3TExaeEdobU5QUDJYbmpNaitHS0tlCnQvYmcydVNsbXYz blFXc3ROLytIb29oRmZKcXB1S1VRWkNKRjRPdDFVOTVKSXE1UEE0T0wyQ2NXbEZ5alJUT2MKanVD WlR0SzUxVDFMMEtIZnhlVHhHOXFjSzgyMVRteFZpM1dWM1EvM1psNktlYmVLcHU5a2hCM2s0TWFV azNFdwpIcUJ1VExpSVVVdDk3M29ZbG5nVE5TZWRpajhBenU4cmJKdnZmcE1vdVYwUXF5ck5DZEE9 Cj1ITUxmCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo= --===============3672514717860252216==--