From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 2/2] wio.cgi: Remove code lines that are commented out
Date: Wed, 13 Apr 2022 11:06:05 +0200 [thread overview]
Message-ID: <c1d6df63-b118-63b3-b264-7eea055f2eba@ipfire.org> (raw)
In-Reply-To: <20220413080020.3664760-2-adolf.belka@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1029 bytes --]
Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>
Am 13.04.2022 um 10:00 schrieb Adolf Belka:
> - These lines were introduced with another patch related to removing IPFire start/stop
> capability from wio
> - The lines were introduced in commented out form and so are doing nothing.
> - It looks like they were added as part of a debugging or investigation work on wio
>
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
> src/wio/wio.cgi | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/src/wio/wio.cgi b/src/wio/wio.cgi
> index 1dcec52fe..a61102894 100644
> --- a/src/wio/wio.cgi
> +++ b/src/wio/wio.cgi
> @@ -128,9 +128,6 @@ my @devs_alt = ('green','blue','orange','red');
>
> my %ifacecolor = ( GREEN => 'wio_run_green', BLUE => 'wio_run_blue', ORANGE => 'wio_run_orange');
>
> -#if ( $netsettings{'RED_TYPE'} eq 'STATIC' || $netsettings{'RED_TYPE'} eq 'DHCP' ) {
> -# %ifacecolor = ( %ifacecolor, RED => 'wio_run_red' );
> -#}
>
> &loadips();
>
next prev parent reply other threads:[~2022-04-13 9:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 8:00 [PATCH 1/2] wio.pl: Fix bug 12799 - Remove code scanning for all potential IP's on RED interface Adolf Belka
2022-04-13 8:00 ` [PATCH 2/2] wio.cgi: Remove code lines that are commented out Adolf Belka
2022-04-13 9:06 ` Bernhard Bitsch [this message]
2022-04-13 8:55 ` [PATCH 1/2] wio.pl: Fix bug 12799 - Remove code scanning for all potential IP's on RED interface Bernhard Bitsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1d6df63-b118-63b3-b264-7eea055f2eba@ipfire.org \
--to=bbitsch@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox