From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter =?utf-8?q?M=C3=BCller?= To: development@lists.ipfire.org Subject: Re: [PATCH] rtl8189fs: add realtek wlan driver Date: Thu, 03 Mar 2022 08:47:37 +0000 Message-ID: In-Reply-To: <20220227091621.3791600-1-arne_f@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3400483284080191841==" List-Id: --===============3400483284080191841== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello Arne, thank you for submitting this. Well, Realtek continues to be a mess when it comes to drivers, but I guess th= ere is little sense in telling our users to complain to their hardware vendor for no= t getting drivers upstream. :-/ Anyway, looks good to me. Reviewed-by: Peter M=C3=BCller Thanks, and best regards, Peter M=C3=BCller > this chip is the successor of the rtl8189es look some boards has > silently switched to the new chip. >=20 > Signed-off-by: Arne Fitzenreiter > --- > lfs/rtl8189fs | 95 +++++++++++++++++++++++ > make.sh | 1 + > src/patches/rtl8189fs/disable_debug.patch | 11 +++ > 3 files changed, 107 insertions(+) > create mode 100644 lfs/rtl8189fs > create mode 100644 src/patches/rtl8189fs/disable_debug.patch >=20 > diff --git a/lfs/rtl8189fs b/lfs/rtl8189fs > new file mode 100644 > index 000000000..7a2b3dca0 > --- /dev/null > +++ b/lfs/rtl8189fs > @@ -0,0 +1,95 @@ > +##########################################################################= ##### > +# = # > +# IPFire.org - A linux based firewall = # > +# Copyright (C) 2007-2022 IPFire Team = # > +# = # > +# This program is free software: you can redistribute it and/or modify = # > +# it under the terms of the GNU General Public License as published by = # > +# the Free Software Foundation, either version 3 of the License, or = # > +# (at your option) any later version. = # > +# = # > +# This program is distributed in the hope that it will be useful, = # > +# but WITHOUT ANY WARRANTY; without even the implied warranty of = # > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the = # > +# GNU General Public License for more details. = # > +# = # > +# You should have received a copy of the GNU General Public License = # > +# along with this program. If not, see . = # > +# = # > +##########################################################################= ##### > + > +##########################################################################= ##### > +# Definitions > +##########################################################################= ##### > + > +include Config > + > +VERSUFIX =3D ipfire$(KCFG) > +MODPATH =3D /lib/modules/$(KVER)-$(VERSUFIX)/extra/wlan > + > +VER =3D 3129a665f835ce0342f9a85a0ce14a556e656b8c > + > +THISAPP =3D rtl8189FS_linux-$(VER) > +DL_FILE =3D $(THISAPP).tar.xz > +DL_FROM =3D $(URL_IPFIRE) > +DIR_APP =3D $(DIR_SRC)/$(THISAPP) > +TARGET =3D $(DIR_INFO)/$(THISAPP)-kmod-$(KVER)-$(VERSUFIX) > + > +##########################################################################= ##### > +# Top-level Rules > +##########################################################################= ##### > + > +objects =3D $(DL_FILE) > + > +$(DL_FILE) =3D $(DL_FROM)/$(DL_FILE) > + > +$(DL_FILE)_MD5 =3D f7c817e89403b8a84a664f326f47c7d7 > + > +install : $(TARGET) > + > +check : $(patsubst %,$(DIR_CHK)/%,$(objects)) > + > +download :$(patsubst %,$(DIR_DL)/%,$(objects)) > + > +md5 : $(subst %,%_MD5,$(objects)) > + > +dist:=20 > + $(PAK) > + > +##########################################################################= ##### > +# Downloading, checking, md5sum > +##########################################################################= ##### > + > +$(patsubst %,$(DIR_CHK)/%,$(objects)) : > + @$(CHECK) > + > +$(patsubst %,$(DIR_DL)/%,$(objects)) : > + @$(LOAD) > + > +$(subst %,%_MD5,$(objects)) : > + @$(MD5) > + > +##########################################################################= ##### > +# Installation Details > +##########################################################################= ##### > + > +$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) > + @$(PREBUILD) > + @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DIR_DL)/$(DL_FILE) > + cd $(DIR_APP) && patch -Np1 < $(DIR_SRC)/src/patches/rtl8189fs/disable_de= bug.patch > + cd $(DIR_APP) && CONFIG_RTL8189FS=3Dm make $(MAKETUNING) \ > + -C /lib/modules/$(KVER)-$(VERSUFIX)/build/ M=3D$(DIR_APP)/ modules > + > + # Install the built kernel modules. > + mkdir -p $(MODPATH) > + cd $(DIR_APP) && for f in $$(ls *.ko); do \ > + /lib/modules/$$(uname -r)$(KCFG)/build/scripts/sign-file sha512 \ > + /lib/modules/$$(uname -r)$(KCFG)/build/certs/signing_key.pem \ > + /lib/modules/$$(uname -r)$(KCFG)/build/certs/signing_key.x509 \ > + $$f; \ > + xz $$f; \ > + install -m 644 $$f.xz $(MODPATH); \ > + done > + > + @rm -rf $(DIR_APP) > + @$(POSTBUILD) > diff --git a/make.sh b/make.sh > index 79798834a..6e84d8d1b 100755 > --- a/make.sh > +++ b/make.sh > @@ -1181,6 +1181,7 @@ buildipfire() { > # multi kernel builds so KCFG is empty > lfsmake2 linux KCFG=3D"" > lfsmake2 rtl8189es KCFG=3D"" > + lfsmake2 rtl8189fs KCFG=3D"" > lfsmake2 rtl8812au KCFG=3D"" > lfsmake2 rtl8822bu KCFG=3D"" > lfsmake2 xradio KCFG=3D"" > diff --git a/src/patches/rtl8189fs/disable_debug.patch b/src/patches/rtl818= 9fs/disable_debug.patch > new file mode 100644 > index 000000000..d29c55e6c > --- /dev/null > +++ b/src/patches/rtl8189fs/disable_debug.patch > @@ -0,0 +1,11 @@ > +diff -Naur rtl8189FS_linux-3129a665f835ce0342f9a85a0ce14a556e656b8c.org/in= clude/autoconf.h rtl8189FS_linux-3129a665f835ce0342f9a85a0ce14a556e656b8c/inc= lude/autoconf.h > +--- rtl8189FS_linux-3129a665f835ce0342f9a85a0ce14a556e656b8c.org/include/a= utoconf.h 2021-10-01 14:51:56.000000000 +0000 > ++++ rtl8189FS_linux-3129a665f835ce0342f9a85a0ce14a556e656b8c/include/autoc= onf.h 2022-02-26 12:00:09.188965578 +0000 > +@@ -224,7 +224,6 @@ > + /* > + * Debug Related Config > + */ > +-#define CONFIG_DEBUG /* DBG_871X, etc... */ > +=20 > + #ifdef CONFIG_DEBUG > + #define DBG 1 // for ODM & BTCOEX debug --===============3400483284080191841==--