From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter =?utf-8?q?M=C3=BCller?= To: development@lists.ipfire.org Subject: Re: Duplicate ipsets listed with Locationblock changes. Date: Thu, 09 Jun 2022 19:54:24 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3113586296834981252==" List-Id: --===============3113586296834981252== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello Stefan, thanks for your mail. > Hello Rob, >=20 > a big thanks for testing and reporting this issue here. >=20 > The main problem has been fixed a while a ago and also merged into next > and the current master branch. So this should be a part of the > upcomming core update. >=20 > After a deeper look I've found that the "rules.pl" file is currently > not shiiped by C168 so the fix would not deplyed. >=20 > @Peter: Please add this file to the C168 filelist. Um, rules.pl _is_ already shipped with https://git.ipfire.org/?p=3Dipfire-2.x= .git;a=3Dcommit;h=3D9efdbe103b8d98b80125407443e906373c534269, at least I think so. Is this not sufficient? Are there any additional steps necessary to have this change applied? Thanks, and best regards, Peter M=C3=BCller >=20 > A big thanks in advance, >=20 > -Stefan >> Hi All, >> >> The tests below were made on my 'Testing' APU4 using CU 168 but as >> Adolf has >> found was identified as CU 167 in the GUI. However I am listing >> duplicate >> ipsets on my production 'Stable' APU4 with CU 167 installed. >> >> Rob >> >> On Tuesday 07 June 2022 15:51 Rob Brewer wrote: >> >>> If I list the installed ipsets with 'ipset -n list' additional >>> ipsets with >>> the suffix 'v4' are sometimes listed. From what I can see this >>> additional >>> 'v4' list is the same size as the set without the 'v4' extension. >>> >>> For instance: with just code AR selected with location-block.cgi: >>> =20 >>> [root(a)ipfire-dev2 ~]# ipset -n list >>> ARv4 >>> AR >>> (code AR id duplicated) >>> >>> if I add code AT to AR and list the sets: >>> [root(a)ipfire-dev2 ~]# ipset -n list >>> AT >>> AR >>> (as expected) >>> >>> and now add code AW to the other 2: >>> [root(a)ipfire-dev2 ~]# ipset -n list >>> ARv4 >>> AT >>> AR >>> ATv4 >>> AW >>> (now codes AR and AT are duplicated) >>> >>> I see this effect on both my core 167 boxes and wasn't aware of >>> this >>> problem before my upgrade from core 161. >>> >>> Rob >> >=20 >=20 --===============3113586296834981252==--