[PATCH 1/2] iproute2: Do not ship /sbin/tipc

[PATCH 1/2] iproute2: Do not ship /sbin/tipc

[Peter Müller]

[-- Attachment #1: Type: text/plain, Size: 878 bytes --]

TIPC (Transparent Inter Process Communication) is a protocol used for
interprocess communication in computer clusters. We do not use this
protocol at all, and the IPFire kernel knows nothing about it (although
Lyins for some reason believes it does). Therefore, there is no sense in
shipping /sbin/tipc, since this executable cannot do anything.

Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
---
 config/rootfiles/common/iproute2 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/config/rootfiles/common/iproute2 b/config/rootfiles/common/iproute2
index 0247aa976..e11bd8892 100644
--- a/config/rootfiles/common/iproute2
+++ b/config/rootfiles/common/iproute2
@@ -24,7 +24,7 @@ sbin/rtmon
 sbin/rtstat
 sbin/ss
 sbin/tc
-sbin/tipc
+#sbin/tipc
 sbin/vdpa
 #usr/include/iproute2
 #usr/include/iproute2/bpf_elf.h
-- 
2.34.1

[PATCH 2/2] iptables: Do not ship libxt_ddcp.so

[Peter Müller]

[-- Attachment #1: Type: text/plain, Size: 848 bytes --]

DCCP (Datagram Congestion Control Protocol) is not in use by IPFire, not
even available as a kernel module. Therefore, there is no sense in
shipping this module, since it cannot do anything.

Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
---
 config/rootfiles/common/iptables | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/config/rootfiles/common/iptables b/config/rootfiles/common/iptables
index b8bf748a5..559958b43 100644
--- a/config/rootfiles/common/iptables
+++ b/config/rootfiles/common/iptables
@@ -86,7 +86,7 @@ lib/xtables/libxt_connlimit.so
 lib/xtables/libxt_connmark.so
 lib/xtables/libxt_conntrack.so
 lib/xtables/libxt_cpu.so
-lib/xtables/libxt_dccp.so
+#lib/xtables/libxt_dccp.so
 lib/xtables/libxt_devgroup.so
 lib/xtables/libxt_dscp.so
 lib/xtables/libxt_ecn.so
-- 
2.34.1

Re: [PATCH 2/2] iptables: Do not ship libxt_ddcp.so

[Adolf Belka]

[-- Attachment #1: Type: text/plain, Size: 983 bytes --]

Reviewed-by: Adolf Belka <adolf.belka(a)ipfire.org>

On 19/03/2022 16:32, Peter Müller wrote:
> DCCP (Datagram Congestion Control Protocol) is not in use by IPFire, not
> even available as a kernel module. Therefore, there is no sense in
> shipping this module, since it cannot do anything.
>
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> ---
>   config/rootfiles/common/iptables | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/config/rootfiles/common/iptables b/config/rootfiles/common/iptables
> index b8bf748a5..559958b43 100644
> --- a/config/rootfiles/common/iptables
> +++ b/config/rootfiles/common/iptables
> @@ -86,7 +86,7 @@ lib/xtables/libxt_connlimit.so
>   lib/xtables/libxt_connmark.so
>   lib/xtables/libxt_conntrack.so
>   lib/xtables/libxt_cpu.so
> -lib/xtables/libxt_dccp.so
> +#lib/xtables/libxt_dccp.so
>   lib/xtables/libxt_devgroup.so
>   lib/xtables/libxt_dscp.so
>   lib/xtables/libxt_ecn.so

Re: [PATCH 2/2] iptables: Do not ship libxt_ddcp.so

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1325 bytes --]

Hello Peter,

I am not sure whether I like the patch.

It becomes difficult and tiresome to keep track of these changes when the next update is due and I would prefer it, if the file wouldn’t be there in the first place. Because then, the next update cannot accidentally ship the file again.

Is there a —-disable-dccp option?

-Michael

> On 19 Mar 2022, at 15:32, Peter Müller <peter.mueller(a)ipfire.org> wrote:
> 
> DCCP (Datagram Congestion Control Protocol) is not in use by IPFire, not
> even available as a kernel module. Therefore, there is no sense in
> shipping this module, since it cannot do anything.
> 
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> ---
> config/rootfiles/common/iptables | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/config/rootfiles/common/iptables b/config/rootfiles/common/iptables
> index b8bf748a5..559958b43 100644
> --- a/config/rootfiles/common/iptables
> +++ b/config/rootfiles/common/iptables
> @@ -86,7 +86,7 @@ lib/xtables/libxt_connlimit.so
> lib/xtables/libxt_connmark.so
> lib/xtables/libxt_conntrack.so
> lib/xtables/libxt_cpu.so
> -lib/xtables/libxt_dccp.so
> +#lib/xtables/libxt_dccp.so
> lib/xtables/libxt_devgroup.so
> lib/xtables/libxt_dscp.so
> lib/xtables/libxt_ecn.so
> -- 
> 2.34.1

Re: [PATCH 1/2] iproute2: Do not ship /sbin/tipc

[Adolf Belka]

[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]

Reviewed-by: Adolf Belka <adolf.belka(a)ipfire.org>

On 19/03/2022 16:32, Peter Müller wrote:
> TIPC (Transparent Inter Process Communication) is a protocol used for
> interprocess communication in computer clusters. We do not use this
> protocol at all, and the IPFire kernel knows nothing about it (although
> Lyins for some reason believes it does). Therefore, there is no sense in
> shipping /sbin/tipc, since this executable cannot do anything.
>
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> ---
>   config/rootfiles/common/iproute2 | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/config/rootfiles/common/iproute2 b/config/rootfiles/common/iproute2
> index 0247aa976..e11bd8892 100644
> --- a/config/rootfiles/common/iproute2
> +++ b/config/rootfiles/common/iproute2
> @@ -24,7 +24,7 @@ sbin/rtmon
>   sbin/rtstat
>   sbin/ss
>   sbin/tc
> -sbin/tipc
> +#sbin/tipc
>   sbin/vdpa
>   #usr/include/iproute2
>   #usr/include/iproute2/bpf_elf.h