From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matthias Fischer <matthias.fischer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] vnstat 2.6: Fix for lfs
Date: Sat, 11 Apr 2020 20:17:34 +0200
Message-ID: <c422d937-9159-5914-9a4e-726c5bd60804@ipfire.org>
In-Reply-To: <6093E18A-FBD1-4A96-93E8-F98784BBBD9D@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4927782642998292596=="
List-Id: <development.lists.ipfire.org>

--===============4927782642998292596==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On 11.04.2020 20:03, Michael Tremer wrote:
> Hi,
>=20
>> On 11 Apr 2020, at 17:39, Matthias Fischer <matthias.fischer(a)ipfire.org>=
 wrote:
>>=20
>> Hi.
>>=20
>> On 11.04.2020 17:28, Michael Tremer wrote:
>>> Hello,
>>>=20
>>> Thanks for the patch, but this only solves one of my concerns.
>>=20
>> You mean the exit status for the 'stop'-section?
>=20
> No, everywhere.

-v please.

'evaluate_retval' is now four times in, status output has been added.

Anything else?

>=20
>>=20
>>> What about printing the colourful exit status more than once?
>>=20
>> Done... ;-)
>>=20
>>> Best,
>>> -Michael
>>>=20
>>>> On 11 Apr 2020, at 15:38, Matthias Fischer <matthias.fischer(a)ipfire.or=
g> wrote:
>>>>=20
>>>> Removed 'sleep 2'
>>>>=20
>>>> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
>>>> ---
>>>> src/initscripts/system/vnstat | 2 --
>>>> 1 file changed, 2 deletions(-)
>>>>=20
>>>> diff --git a/src/initscripts/system/vnstat b/src/initscripts/system/vnst=
at
>>>> index bcc19c3ab..a21905d75 100755
>>>> --- a/src/initscripts/system/vnstat
>>>> +++ b/src/initscripts/system/vnstat
>>>> @@ -20,14 +20,12 @@ case "$1" in
>>>>=20
>>>> 		boot_mesg "Starting vnstatd..."
>>>> 		loadproc /usr/sbin/vnstatd -d --alwaysadd
>>>> -		sleep 2
>>>> 		evaluate_retval
>>>> 		;;
>>>>=20
>>>> 	stop)
>>>> 		boot_mesg "Stopping vnstatd..."
>>>> 		killproc /usr/sbin/vnstatd
>>>> -		sleep 2
>>>> 		evaluate_retval
>>>>=20
>>>> 		umount_ramdisk "${VNSTATLOG}"
>>>> --=20
>>>> 2.18.0
>>>>=20
>>>=20
>>=20
>=20


--===============4927782642998292596==--