From: "Peter Müller" <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] OpenVPN: Delete RRD dir if connection is deleted
Date: Sat, 28 Mar 2020 09:25:00 +0000 [thread overview]
Message-ID: <c4e7cd49-f8b8-c88e-c193-20ccb4bf856a@ipfire.org> (raw)
In-Reply-To: <20200328083224.2925-1-ummeegge@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 956 bytes --]
Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org>
In my opinion, this fixes #11713.
> Signed-off-by: Erik Kapfer <ummeegge(a)ipfire.org>
> ---
> html/cgi-bin/ovpnmain.cgi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
> index ce9524df7..00ecd77a0 100644
> --- a/html/cgi-bin/ovpnmain.cgi
> +++ b/html/cgi-bin/ovpnmain.cgi
> @@ -2513,7 +2513,7 @@ else
> # CCD end
> # Update collectd configuration and delete all RRD files of the removed connection
> &writecollectdconf();
> - system ("/usr/local/bin/openvpnctrl -drrd $confighash{$cgiparams{'KEY'}}[1]");
> + system ('/usr/local/bin/openvpnctrl', '-drrd', $confighash{$cgiparams{'KEY'}}[1]);
>
> delete $confighash{$cgiparams{'KEY'}};
> my $temp2 = `/usr/bin/openssl ca -gencrl -out ${General::swroot}/ovpn/crls/cacrl.pem -config ${General::swroot}/ovpn/openssl/ovpn.cnf`;
>
next prev parent reply other threads:[~2020-03-28 9:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-28 8:32 Erik Kapfer
2020-03-28 9:25 ` Peter Müller [this message]
2020-03-28 9:45 ` ummeegge
2020-04-11 8:06 ` ummeegge
2020-04-11 10:46 ` Michael Tremer
2020-04-11 11:59 ` ummeegge
2020-04-11 12:24 ` Michael Tremer
2020-04-11 12:52 ` ummeegge
2020-04-23 20:03 ` Michael Tremer
2020-05-04 14:17 ` ummeegge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4e7cd49-f8b8-c88e-c193-20ccb4bf856a@ipfire.org \
--to=peter.mueller@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox