From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter =?utf-8?q?M=C3=BCller?= To: development@lists.ipfire.org Subject: Re: [PATCH] stripper: Strip any PIE executables Date: Wed, 06 Jul 2022 10:00:35 +0000 Message-ID: In-Reply-To: <8A4EB246-546C-428D-A538-B9D6BFB9CD62@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2269754762657256863==" List-Id: --===============2269754762657256863== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello Michael, thanks for your swift response. Okay, I will then just bump the version number of dnsdist. All the best, Peter M=C3=BCller > Good question. I did not even think about this. >=20 > I could not find many executables that fell into this category. Maybe about= 10. Out of those, dnsdist was the largest one - by far. >=20 > So I would say, it isn=E2=80=99t worth it except for dnsdist. >=20 > -Michael >=20 >> On 6 Jul 2022, at 10:56, Peter M=C3=BCller wr= ote: >> >> Hello Michael, >> >> just a short follow-up question on this: Do we need to re-ship all affecte= d packages again? >> Or is it fine to let users benefit from stripped PIE executables when we u= pdate affected >> components anyway? >> >> Thanks, and best regards, >> Peter M=C3=BCller >> >> >>> Reviewed-by: Peter M=C3=BCller >>> >>>> Fixes: #12894 >>>> Signed-off-by: Michael Tremer >>>> --- >>>> src/stripper | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/src/stripper b/src/stripper >>>> index fadbc514b..4014f03a4 100755 >>>> --- a/src/stripper >>>> +++ b/src/stripper >>>> @@ -38,6 +38,10 @@ function _strip() { >>>> args+=3D( "--strip-all" ) >>>> ;; >>>> + *Type:*"DYN (Position-Independent Executable file)"*) >>>> + args+=3D( "--strip-all" ) >>>> + ;; >>>> + >>>> # Binaries >>>> *Type:*"EXEC (Executable file)"*) >>>> args+=3D( "--strip-all" ) >=20 --===============2269754762657256863==--