From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Adolf Belka (ipfire-dev)" <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] wirelessclient.cgi: Fix for bug #12571
Date: Fri, 12 Feb 2021 13:05:08 +0100
Message-ID: <c6f7c77d-88bf-2554-133e-44d60b8c70fc@ipfire.org>
In-Reply-To: <F1FE6E19-8FCA-403B-B2CE-762BF22DE112@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5225802096351440212=="
List-Id: <development.lists.ipfire.org>

--===============5225802096351440212==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Michael,

On 12/02/2021 12:48, Michael Tremer wrote:
> Hi,
>=20
> This patch looks good.
>=20
> What would help me a little bit more when writing the change log is to put =
what it does in the subject line (i.e. first line of the Git message).
>=20
> In this case it could have been something along the lines of (Correct order=
 of priority).
>=20
> I noticed this when I wrote the change log for Core Update 154 and I had to=
 go and lookup the bug number which took me some extra time.
>=20
> So, not a big issue here, but it is easier to spot what the patch does when=
 it is in the headline.
>=20
> The bug number should be in the body with in a =E2=80=9CFixes: #12571=E2=80=
=9D style.

Makes sense. If you have a few bug fixes in the update you don't want to have=
 to go to bugzilla for each one to find out what it does.

I will keep that in mind.

Thanks for the input.

Regards,
Adolf.
>=20
> Best,
> -Michael
>=20
>> On 11 Feb 2021, at 12:41, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>
>> - Wirelessclient shows priority 0 to be most preferred and priority 4 as
>> least preferred. Based on forum posters experience and the wpa_supplicant
>> man page it is the other way round.
>> - This patch moves the least preferred title to priority 0 and vice versa
>> - Will ask bug reporter to test out the patch and confirm it works. The pa=
ge
>> is only shown if you have a wifi connection on red.
>>
>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>> ---
>> html/cgi-bin/wirelessclient.cgi | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/html/cgi-bin/wirelessclient.cgi b/html/cgi-bin/wirelessclient=
.cgi
>> index e8c3c9628..b1679c128 100644
>> --- a/html/cgi-bin/wirelessclient.cgi
>> +++ b/html/cgi-bin/wirelessclient.cgi
>> @@ -602,11 +602,11 @@ sub showEditBox() {
>> 					</td>
>> 					<td width=3D'40%'>
>> 						<select name=3D'PRIO'>
>> -							<option value=3D"0" $selected{'PRIO'}{'0'}>0 ($Lang::tr{'most pref=
erred'})</option>
>> +							<option value=3D"0" $selected{'PRIO'}{'0'}>0 ($Lang::tr{'least pre=
ferred'})</option>
>> 							<option value=3D"1" $selected{'PRIO'}{'1'}>1</option>
>> 							<option value=3D"2" $selected{'PRIO'}{'2'}>2</option>
>> 							<option value=3D"3" $selected{'PRIO'}{'3'}>3</option>
>> -							<option value=3D"4" $selected{'PRIO'}{'4'}>4 ($Lang::tr{'least pre=
ferred'})</option>
>> +							<option value=3D"4" $selected{'PRIO'}{'4'}>4 ($Lang::tr{'most pref=
erred'})</option>
>> 						</select>
>> 					</td>
>> 					<td colspan=3D"2" width=3D'40%'></td>
>> --=20
>> 2.30.1
>>
>=20

--===============5225802096351440212==--