Re: IPCop Banish Addon for IPFire

[Matthias Fischer <matthias.fischer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1904 bytes --]

Hi,

On 06.01.2019 19:12, Bob Brewer wrote:
> Hi,
> 
> I have ported a version of the old IPCop addon 'Banish' to IPFire and use it 
> to maintain my local blacklist. Banish was one of my favorite IPCop addons 
> but it ceased to be maintained about 10 years ago and for later versions of 
> IPCop I installed a locally written text version of Banish to maintain the 
> Blacklist.
> 
> This new IPFire version restores all the original GUI functionality and is 
> currently running on an  PC Engines ‐ apu2 with  IPFire 2.21 (i586) - Core 
> Update 125.
> 
> If you would like to try this addon, I have uploaded it to 
> https://github.com/Grantura/Banish-IPFire
> grab the self installing file banish-ipfire.tar-1.0.1.gz
> and extract it to /tmp.
> 
> The install also contains an uninstall script should you want to back out at 
> any time.
> ...

Being curious - as always - I tried to install Banish on my testmachine.

But the install script has a problem:

***SNIP***
[root(a)ipfiretest Banish-IPFire]# ./install_Banish.sh
Starting Banish-IPFire 1.0.1 installation

Checking if files extracted to /tmp....OK!
Checking files.........................OK!
...OK!
Backing up files.....................Done!
Extracting files.....................Done!
Installing system files..............Done!
Appending to files...................Done!
Starting Banish......................./install_Banish.sh: line 258:
/etc/rc.d/init.d/banish: No such file or directory
Done!
Cleaning up..........................Done!
***SNAP***

It seems that line 170 uses the wrong destination:

...
/bin/cp -p Banish/etc/rc.d/init.d/rc.banish /etc/rc.d/init.d/
...

This should have been '/etc/rc.d/init.d/banish'!?

The symlinks in line 173-175 are therefore affected, too. Banish won't
start.

I corrected this manually, seems to work.

Testing...

Best,
Matthias