Re: [PATCH 0/2] Added new Package node_exporter

[Adolf Belka <adolf.belka@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 2640 bytes --]

Hi Holger,

Welcome to the development team and thanks for your patch submission.

I think that there is some additional information required in this covering note.

I think that it would be good to have some additional information about the use case for node_exporter compared to icinga, monit, zabbix_agentd, nagios, etc that already exist as addons in IPFire. What is it that node_exporter brings that cannot be accomplished by those other packages and warrants it being added to the list.

Historically many addons have been launched and then shortly afterwards the person who introduced the addon has stopped supporting the maintenance of it with updates, fixes etc. Typically then the package has ended up getting out of date.

I believe that the core devs will expect, if the addon is agreed to be a valuable additional package, a longer term commitment from yourself to take on the role of maintainer for the package. It would be good to have that commitment in this covering note.

Regards,

Adolf.

On 06/05/2021 21:46, Holger Sunke wrote:
> These patches add the new package node_exporter as discussed in the form thread:
> https://community.ipfire.org/t/please-add-prometheus-exporter/3555
>
> GO language is required to compile node_exporter. In order to compile
> node_exporter for i586 arch, "go" package supported architecture
> must be extended for this.
> You'll likely want to download packages and adjust DL_FROM variables
> in "go" and "node_exporter" LFS scripts.
>
> Holger Sunke (2):
>    Added i586/386 support for GO language required for node_exporter.
>    Added new node_exporter package.
>
>   config/rootfiles/packages/node_exporter       |  3 +
>   lfs/Config                                    |  4 +
>   lfs/go                                        |  6 +-
>   lfs/node_exporter                             | 88 +++++++++++++++++++
>   make.sh                                       |  1 +
>   src/paks/node_exporter/install.sh             | 31 +++++++
>   src/paks/node_exporter/uninstall.sh           | 30 +++++++
>   src/paks/node_exporter/update.sh              | 27 ++++++
>   ..._exporter-configurable-initd-options.patch | 48 ++++++++++
>   9 files changed, 235 insertions(+), 3 deletions(-)
>   create mode 100644 config/rootfiles/packages/node_exporter
>   create mode 100644 lfs/node_exporter
>   create mode 100644 src/paks/node_exporter/install.sh
>   create mode 100644 src/paks/node_exporter/uninstall.sh
>   create mode 100644 src/paks/node_exporter/update.sh
>   create mode 100644 src/patches/node_exporter-configurable-initd-options.patch
>