Re: [PATCH 2/3] dhcp: update lfs file after gzip update to fix build fail

[Marcel Lorenz <marcel.lorenz@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 3036 bytes --]

:) as you wish:

*****
Now you can type make to build ISC DHCP

cd /usr/src/dhcp-4.3.1 && make -j5
make[1]: Entering directory '/usr/src/dhcp-4.3.1'
Making all in bind
make[2]: Entering directory '/usr/src/dhcp-4.3.1/bind'
tar: Archive is compressed. Use -z option
tar: Error is not recoverable: exiting now
Makefile:33: recipe for target 'all' failed
****

Marcel



Am 2016-03-08 18:06, schrieb Michael Tremer:
> I think this *should not* break. This might be a regression in gzip
> then.
> 
> Do you have a snippet of the build log of the error?
> 
> -Michael
> 
> On Tue, 2016-03-08 at 18:03 +0100, Marcel Lorenz wrote:
>> Am 2016-03-08 15:26, schrieb Michael Tremer:
>> > Hi,
>> >
>> > what is the build issue you are trying to solve here?
>> >
>> > Copying in a highly outdated version of the bind libs is from my
>> > point
>> > of view a big security risk.
>> >
>> > -Michael
>> >
>> > On Tue, 2016-03-08 at 11:09 +0100, Marcel Lorenz wrote:
>> > > Signed-off-by: Marcel Lorenz <marcel.lorenz(a)ipfire.org>
>> Hi,
>> 
>> you have right, the old bind is a security risk!
>> 
>> This is the current lfs file without patch:
>> *****
>> 	cd $(DIR_APP) && patch -Np1 < 
>> $(DIR_SRC)/src/patches/dhcp/dhcp-stateless-DUID-LLT.patch
>> 
>> 	# Remove bundled BIND stuff.
>> 	# (requires newer autoconf)
>> 	#rm -rfv $(DIR_APP)/bind/bind.tar.gz
>> 	#cd $(DIR_APP) && autoreconf --verbose --force --install
>> 
>> 	cd $(DIR_APP) && \
>> *****
>> 
>> The error in log is "use tar axf to extract..."
>> 
>> The old bind is extracted while make runs. After gzip update this
>> not 
>> working more automatic.
>> They only need some files from bind archive to built the isc-dhcp 
>> package. Bind itself is not used.
>> (When i understood this correct)
>> 
>> The: "cd $(DIR_APP)/bind && tar -axf bind.tar.gz" extract this
>> before 
>> make runs.. That's all..
>> 
>> Greetings,
>> Marcel
>> 
>> 
>> > >
>> > > ---
>> > >  lfs/dhcp | 10 ++--------
>> > >  1 file changed, 2 insertions(+), 8 deletions(-)
>> > >
>> > > diff --git a/lfs/dhcp b/lfs/dhcp
>> > > index 9a89d40..cec8628 100644
>> > > --- a/lfs/dhcp
>> > > +++ b/lfs/dhcp
>> > > @@ -99,17 +99,11 @@ $(TARGET) : $(patsubst
>> > > %,$(DIR_DL)/%,$(objects))
>> > >  	cd $(DIR_APP) && patch -Np1 <
>> > > $(DIR_SRC)/src/patches/dhcp/dhcp-gpxe-cid.patch
>> > >  	cd $(DIR_APP) && patch -Np1 <
>> > > $(DIR_SRC)/src/patches/dhcp/dhcp-stateless-DUID-LLT.patch
>> > >  
>> > > -	# Remove bundled BIND stuff.
>> > > -	# (requires newer autoconf)
>> > > -	#rm -rfv $(DIR_APP)/bind/bind.tar.gz
>> > > -	#cd $(DIR_APP) && autoreconf --verbose --force --install
>> > > -
>> > > -	cd $(DIR_APP) && \
>> > > -		./configure \
>> > > +	cd $(DIR_APP)/bind && tar -axf bind.tar.gz
>> > > +	cd $(DIR_APP) && ./configure \
>> > >  			--prefix=/usr \
>> > >  			--sysconfdir=/etc/dhcp \
>> > >  			--with-srv-lease-
>> > > file=/var/state/dhcp/dhcpd.leases \
>> > > -			--disable-static \
>> > >  			--enable-paranoia \
>> > >  			--enable-early-chroot \
>> > >  			--disable-dhcpv6
>>