From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter =?utf-8?q?M=C3=BCller?= <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 1/3] dhcpcd: Force setting MTU through dhcpcd
Date: Tue, 22 Feb 2022 19:16:39 +0000
Message-ID: <cb112460-a50f-b4c4-079b-fd231256c858@ipfire.org>
In-Reply-To: <20220222121806.1208994-1-michael.tremer@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4632836442513026720=="
List-Id: <development.lists.ipfire.org>

--===============4632836442513026720==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>

> The DHCP server can instruct clients to configure a certain MTU.
>=20
> This used to be done by setting the MTU of the interface. However,
> dhcpcd has changed this behaviour using routes to.
>=20
> We used to have a modified version of the old mechanism which no longer
> works well with the new system and is therefore to be dropped.
>=20
> This is the first commit in the series implementing the new behaviour
> and telling dhcpcd to use the configured MTU.
>=20
> Fixes: #12563
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
>   src/initscripts/networking/functions.network | 11 ++++++++---
>   1 file changed, 8 insertions(+), 3 deletions(-)
>=20
> diff --git a/src/initscripts/networking/functions.network b/src/initscripts=
/networking/functions.network
> index 7ec50f436..eae4a7b7c 100644
> --- a/src/initscripts/networking/functions.network
> +++ b/src/initscripts/networking/functions.network
> @@ -61,7 +61,7 @@ dhcpcd_start() {
>   	# This function will start a dhcpcd on a speciefied device.
>  =20
>   	local device=3D"$1"
> -	local dhcp_start=3D""
> +	local dhcp_start=3D()
>  =20
>   	boot_mesg -n "Starting dhcpcd on the ${device} interface..."
>  =20
> @@ -76,11 +76,16 @@ dhcpcd_start() {
>  =20
>   	# Check if a DHCP hostname has been set.
>   	if [ -n "${RED_DHCP_HOSTNAME}" ]; then
> -		dhcp_start+=3D"-h ${RED_DHCP_HOSTNAME}"
> +		dhcp_start+=3D( "-h" "${RED_DHCP_HOSTNAME}" )
> +	fi
> +
> +	# Tell dhcpcd to use the configured MTU
> +	if [ -n "${RED_DHCP_FORCE_MTU}" ]; then
> +		dhcp_start+=3D( "--static" "mtu=3D${RED_DHCP_FORCE_MTU}" )
>   	fi
>  =20
>   	# Start dhcpcd.
> -	/sbin/dhcpcd ${dhcp_start} ${device} >/dev/null 2>&1
> +	/sbin/dhcpcd "${dhcp_start[@]}" ${device} >/dev/null 2>&1
>   	ret=3D"$?"
>  =20
>   	if [ "${ret}" -eq 0 ]; then

--===============4632836442513026720==--