Patches being worked on

Patches being worked on

[Adolf Belka]

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

Hi All,


For info I am working on the following update patches:-

bash
binutils
bison
bzip2
diffutils
ed
gawk
lm_sensors
perl

Regards,

Adolf

-- 
Sent from my laptop

Re: Patches being worked on

[Adolf Belka]

[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]

Hi All,

I have dropped bash from my updates.

I was able to confirm, by review of the patches and tarball files that

bash-4.0-paths-1.patch
bash-4.0-profile-1.patch
bash-3.2-ssh_source_bash.patch

are all still needed.

However the bash-5.0 set of 18 patches I could not find all of the patch 
parts in the tarball files. Doing the build caused several hunks to fail 
because a match could not be found. Some matched because the changes 
were now incorporated.

Reviewing the first patch there were several of the lines from the 
previous version that are no longer in the newer tarball files.

However I am unable to tell if this is because the changes are now 
incorporated in the tarball files but in a different way to the patch or 
if they are missing and a new set of patches is required to implement 
the same changes.

This update needs someone else to work on it with better skills than mine.

Regards,

Adolf.

On 28/03/2021 10:33, Adolf Belka wrote:
> Hi All,
>
>
> For info I am working on the following update patches:-
>
> bash
> binutils
> bison
> bzip2
> diffutils
> ed
> gawk
> lm_sensors
> perl
>
> Regards,
>
> Adolf
>
-- 
Sent from my laptop

Re: Patches being worked on

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1976 bytes --]

Hello,

> On 28 Mar 2021, at 14:52, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
> 
> Hi All,
> 
> I have dropped bash from my updates.
> 
> I was able to confirm, by review of the patches and tarball files that
> 
> bash-4.0-paths-1.patch
> bash-4.0-profile-1.patch
> bash-3.2-ssh_source_bash.patch
> 
> are all still needed.

Yes.

> However the bash-5.0 set of 18 patches I could not find all of the patch parts in the tarball files. Doing the build caused several hunks to fail because a match could not be found. Some matched because the changes were now incorporated.

These will all be upstreamed. Instead of releasing a tarball for a minor release, GNU bash only releases the patches. So instead of 5.0.1 you would have one patch to download and another one for 5.0.2, and so on. We appear to be on 5.0.18 then.

> Reviewing the first patch there were several of the lines from the previous version that are no longer in the newer tarball files.

You can just drop them and download the latest set for the 5.1 branch:

  https://ftp.gnu.org/gnu/bash/bash-5.1-patches/

> However I am unable to tell if this is because the changes are now incorporated in the tarball files but in a different way to the patch or if they are missing and a new set of patches is required to implement the same changes.

Ideally “patch” should tell you that the patch has already been applied. If it had to be modified during the backport, it might not be able to detect this.

> This update needs someone else to work on it with better skills than mine.

Just drop the patches and keep the other ones :)

-Michael

> Regards,
> 
> Adolf.
> 
> On 28/03/2021 10:33, Adolf Belka wrote:
>> Hi All,
>> 
>> 
>> For info I am working on the following update patches:-
>> 
>> bash
>> binutils
>> bison
>> bzip2
>> diffutils
>> ed
>> gawk
>> lm_sensors
>> perl
>> 
>> Regards,
>> 
>> Adolf
>> 
> -- 
> Sent from my laptop
> 

Re: Patches being worked on

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 700 bytes --]

Hello,

> On 28 Mar 2021, at 09:33, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
> 
> Hi All,
> 
> 
> For info I am working on the following update patches:-
> 
> bash

Could you please update readline together with bash?

They belong together.

> binutils

Peter worked on this before and said the build crashes in various places. There should be something you can use as a start to confirm.

> bison
> bzip2
> diffutils
> ed
> gawk
> lm_sensors
> perl

Perl might be a massive one because there are so many dependencies that need to be update at the same time. Let me know how this goes :)

-Michael

> Regards,
> 
> Adolf
> 
> -- 
> Sent from my laptop
> 

Re: Patches being worked on

[Adolf Belka]

[-- Attachment #1: Type: text/plain, Size: 1557 bytes --]

Hi Michael,

On 29/03/2021 22:11, Michael Tremer wrote:
> Hello,
> 
>> On 28 Mar 2021, at 09:33, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>
>> Hi All,
>>
>>
>> For info I am working on the following update patches:-
>>
>> bash
> 
> Could you please update readline together with bash?
> 
> They belong together.
I will do that, together with your input in the other email about how to deal with bash.
> 
>> binutils
> 
> Peter worked on this before and said the build crashes in various places. There should be something you can use as a start to confirm.
Yes, I already found issues, which is why it was taken out of the patches I submitted. I will go back and have another look at it.
> 
>> bison
>> bzip2
>> diffutils
>> ed
>> gawk
>> lm_sensors
>> perl
> 
> Perl might be a massive one because there are so many dependencies that need to be update at the same time. Let me know how this goes :)
That I have found already. I am currently working on it and struggling a bit. I am making small progress but then hit another issue. My current one is having built it and adjusted mpfire-ipfire to use the correct directory names (based on perl version) I now have a problem at the building cdrom stage which looks to be related to the rootfile. A lot of it seems to be missing including the /usr/bin/perl entries. I will investigate further but may need to come back with the error for advice and guidance.

Regards,
Adolf.
> 
> -Michael
> 
>> Regards,
>>
>> Adolf
>>
>> -- 
>> Sent from my laptop
>>
> 

Re: Patches being worked on

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1952 bytes --]

Hello,

> On 29 Mar 2021, at 21:46, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
> 
> Hi Michael,
> 
> On 29/03/2021 22:11, Michael Tremer wrote:
>> Hello,
>>> On 28 Mar 2021, at 09:33, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>> 
>>> Hi All,
>>> 
>>> 
>>> For info I am working on the following update patches:-
>>> 
>>> bash
>> Could you please update readline together with bash?
>> They belong together.
> I will do that, together with your input in the other email about how to deal with bash.
>>> binutils
>> Peter worked on this before and said the build crashes in various places. There should be something you can use as a start to confirm.
> Yes, I already found issues, which is why it was taken out of the patches I submitted. I will go back and have another look at it.

You can post these things on the list, just for reference or to check if anybody else has an idea. I would like to know what breaks, even if we cannot do something about it without any further and bigger works.

>>> bison
>>> bzip2
>>> diffutils
>>> ed
>>> gawk
>>> lm_sensors
>>> perl
>> Perl might be a massive one because there are so many dependencies that need to be update at the same time. Let me know how this goes :)
> That I have found already. I am currently working on it and struggling a bit. I am making small progress but then hit another issue. My current one is having built it and adjusted mpfire-ipfire to use the correct directory names (based on perl version) I now have a problem at the building cdrom stage which looks to be related to the rootfile. A lot of it seems to be missing including the /usr/bin/perl entries. I will investigate further but may need to come back with the error for advice and guidance.

Yes, it is a lot of try-and-error and very time-consuming :)

-Michael

> Regards,
> Adolf.
>> -Michael
>>> Regards,
>>> 
>>> Adolf
>>> 
>>> -- 
>>> Sent from my laptop
>>>