Re: [PATCH] Suggested fix for 'rngd' service status

["Peter Müller" <peter.mueller@link38.eu>]

[-- Attachment #1: Type: text/plain, Size: 1652 bytes --]

Hello,

I support this patch. Quite a while ago, there was a similar
one on this list but was not merged eventually.

Michael stated it should be fixed in the upstream channel (which
is basically right) - however, looking at our recent trouble
with this software, I doubt it makes much sense to delay this
until it reached the origin repository.

Best regards,
Peter Müller

> Hi,
> 
> Since https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=fd0a0384f07b399e9cb4cf46b4c5722b809ffe6a
> 'rngd' is running again with much higher values. STATUS / ENTROPY shows RUNNING. Thanks! ;-)
> 
> But '/var/run/rngd.pid' is created with wrong rights (0600). Therefore, STATUS / SERVICES tells me
> 'rngd' is stopped.
> 
> The suggested fix checks whether '/var/run/rngd.pid' exists and sets rights accordingly.
> 
> Best,
> Matthias
> 
> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> ---
>  src/initscripts/system/rngd | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/initscripts/system/rngd b/src/initscripts/system/rngd
> index 91b70a7b4..8fe5c9363 100644
> --- a/src/initscripts/system/rngd
> +++ b/src/initscripts/system/rngd
> @@ -15,6 +15,9 @@ case "${1}" in
>  	start)
>  		boot_mesg "Starting Random Number Generator Daemon..."
>  		loadproc /usr/sbin/rngd --quiet
> +		if [ -f "/var/run/rngd.pid" ]; then
> +			chmod 644 /var/run/rngd.pid
> +		fi
>  		;;
>  
>  	stop)
> 

-- 
Microsoft DNS service terminates abnormally when it recieves a response
to a DNS query that was never made.  Fix Information: Run your DNS
service on a different platform.
		-- bugtraq