public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
* [PATCH] OpenSSH: do not ship ssh-keysign anymore
@ 2021-05-16 20:48 Peter Müller
  2021-05-17 10:58 ` Adolf Belka
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Müller @ 2021-05-16 20:48 UTC (permalink / raw)
  To: development

[-- Attachment #1: Type: text/plain, Size: 741 bytes --]

To my surprise, this binary comes with suid flag set, and since we do
not have SSH key signing enabled, there is no need to ship it with
IPFire.

Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
---
 config/rootfiles/common/openssh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/config/rootfiles/common/openssh b/config/rootfiles/common/openssh
index f2f8ea6c5..c3666d914 100644
--- a/config/rootfiles/common/openssh
+++ b/config/rootfiles/common/openssh
@@ -19,7 +19,7 @@ usr/bin/ssh-keygen
 usr/bin/ssh-keyscan
 #usr/lib/openssh
 usr/lib/openssh/sftp-server
-usr/lib/openssh/ssh-keysign
+#usr/lib/openssh/ssh-keysign
 usr/lib/openssh/ssh-pkcs11-helper
 usr/lib/openssh/ssh-sk-helper
 usr/sbin/sshd
-- 
2.26.2

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] OpenSSH: do not ship ssh-keysign anymore
  2021-05-16 20:48 [PATCH] OpenSSH: do not ship ssh-keysign anymore Peter Müller
@ 2021-05-17 10:58 ` Adolf Belka
  0 siblings, 0 replies; 2+ messages in thread
From: Adolf Belka @ 2021-05-17 10:58 UTC (permalink / raw)
  To: development

[-- Attachment #1: Type: text/plain, Size: 900 bytes --]

Reviewed-by: Adolf Belka <adolf.belka(a)ipfire.org>

On 16/05/2021 22:48, Peter Müller wrote:
> To my surprise, this binary comes with suid flag set, and since we do
> not have SSH key signing enabled, there is no need to ship it with
> IPFire.
>
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> ---
>   config/rootfiles/common/openssh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/config/rootfiles/common/openssh b/config/rootfiles/common/openssh
> index f2f8ea6c5..c3666d914 100644
> --- a/config/rootfiles/common/openssh
> +++ b/config/rootfiles/common/openssh
> @@ -19,7 +19,7 @@ usr/bin/ssh-keygen
>   usr/bin/ssh-keyscan
>   #usr/lib/openssh
>   usr/lib/openssh/sftp-server
> -usr/lib/openssh/ssh-keysign
> +#usr/lib/openssh/ssh-keysign
>   usr/lib/openssh/ssh-pkcs11-helper
>   usr/lib/openssh/ssh-sk-helper
>   usr/sbin/sshd

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-17 10:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-16 20:48 [PATCH] OpenSSH: do not ship ssh-keysign anymore Peter Müller
2021-05-17 10:58 ` Adolf Belka

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox