From: Bernhard Held <berny156@gmx.de>
To: development@lists.ipfire.org
Subject: Re: [PATCH] Network::network_equal: fix definition check of array
Date: Mon, 12 Feb 2018 01:19:02 +0100 [thread overview]
Message-ID: <ceaad69d-3a26-00c6-44c6-6ce0927d52c4@gmx.de> (raw)
In-Reply-To: <1518392280.2498.23.camel@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 738 bytes --]
On 02/12/2018 at 12:38 AM, Michael Tremer wrote:
> Hello,
>
> this patch shows the following perl errors:
>
> defined(@array) is deprecated at config/cfgroot/network-functions.pl line 114.
> (Maybe you should just omit the defined()?)
> defined(@array) is deprecated at config/cfgroot/network-functions.pl line 114.
> (Maybe you should just omit the defined()?)
Interesting, I'm testing on IPFire 2.19. Here perl 5.12 prefers the '$'.
My host with Perl 5.26 indeed prefers the '@' as well.
Which perl versions apply for network-functions.pl?
> You can use the testsuite at the bottom of the file to confirm that the
> functions are doing what they are supposed to do.
Thanks, this helps ;-)
Regards,
Bernhard
next prev parent reply other threads:[~2018-02-12 0:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-11 23:19 Bernhard Held
2018-02-11 23:38 ` Michael Tremer
2018-02-12 0:19 ` Bernhard Held [this message]
2018-02-12 11:08 ` Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ceaad69d-3a26-00c6-44c6-6ce0927d52c4@gmx.de \
--to=berny156@gmx.de \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox