From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernhard Held To: development@lists.ipfire.org Subject: Re: [PATCH] Network::network_equal: fix definition check of array Date: Mon, 12 Feb 2018 01:19:02 +0100 Message-ID: In-Reply-To: <1518392280.2498.23.camel@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1679248337900640578==" List-Id: --===============1679248337900640578== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 02/12/2018 at 12:38 AM, Michael Tremer wrote: > Hello, >=20 > this patch shows the following perl errors: >=20 > defined(@array) is deprecated at config/cfgroot/network-functions.pl line 1= 14. > (Maybe you should just omit the defined()?) > defined(@array) is deprecated at config/cfgroot/network-functions.pl line 1= 14. > (Maybe you should just omit the defined()?) Interesting, I'm testing on IPFire 2.19. Here perl 5.12 prefers the '$'. My host with Perl 5.26 indeed prefers the '@' as well. Which perl versions apply for network-functions.pl? > You can use the testsuite at the bottom of the file to confirm that the > functions are doing what they are supposed to do. Thanks, this helps ;-) Regards, Bernhard --===============1679248337900640578==--