glitch in patchwork?

glitch in patchwork?

[Paul Simmons]

[-- Attachment #1: Type: text/plain, Size: 553 bytes --]

Hey, All.

I've noticed occasional discrepancies in PATCHWORK.

For example, 
https://patchwork.ipfire.org/project/ipfire/patch/20221108200911.11156-1-robin.roevens(a)disroot.org/ 
status displays as "New", but was committed as 
https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=e47370a167869da39c5962ff9f9f032d7bd995ee

This isn't a show stopper, but I thought I should point it out.

Thanks, and happy coding,
Paul

-- 
As I’ve gotten older, people think I’ve become lazy.  The truth is I’m just being more energy efficient.

Re: glitch in patchwork?

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1197 bytes --]

Hello Paul,

This does happen sometimes, indeed.

Mostly it happens with any patches that contain non-ascii characters.

Patchwork calculates a hash over a patch and stores that hash in its database. We then calculate hashes for all commits and use those to find any patches in the database. When there are any funny characters in it, it does not seem to work.

I would consider this a bug in Patchwork, but did not have the time to investigate, yet.

So, those patches need to be manually marked as Staged or Merged.

-Michael

> On 24 Nov 2022, at 00:42, Paul Simmons <mbatranch(a)gmail.com> wrote:
> 
> Hey, All.
> 
> I've noticed occasional discrepancies in PATCHWORK.
> 
> For example, https://patchwork.ipfire.org/project/ipfire/patch/20221108200911.11156-1-robin.roevens(a)disroot.org/ status displays as "New", but was committed as https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=e47370a167869da39c5962ff9f9f032d7bd995ee
> 
> This isn't a show stopper, but I thought I should point it out.
> 
> Thanks, and happy coding,
> Paul
> 
> -- 
> As I’ve gotten older, people think I’ve become lazy.  The truth is I’m just being more energy efficient.
> 

Re: glitch in patchwork?

[Paul Simmons]

[-- Attachment #1: Type: text/plain, Size: 1505 bytes --]

On 11/24/22 05:32, Michael Tremer wrote:
> Hello Paul,
>
> This does happen sometimes, indeed.
>
> Mostly it happens with any patches that contain non-ascii characters.
>
> Patchwork calculates a hash over a patch and stores that hash in its database. We then calculate hashes for all commits and use those to find any patches in the database. When there are any funny characters in it, it does not seem to work.
>
> I would consider this a bug in Patchwork, but did not have the time to investigate, yet.
>
> So, those patches need to be manually marked as Staged or Merged.
>
> -Michael
>
>> On 24 Nov 2022, at 00:42, Paul Simmons <mbatranch(a)gmail.com> wrote:
>>
>> Hey, All.
>>
>> I've noticed occasional discrepancies in PATCHWORK.
>>
>> For example, https://patchwork.ipfire.org/project/ipfire/patch/20221108200911.11156-1-robin.roevens(a)disroot.org/ status displays as "New", but was committed as https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=e47370a167869da39c5962ff9f9f032d7bd995ee
>>
>> This isn't a show stopper, but I thought I should point it out.
>>
>> Thanks, and happy coding,
>> Paul
>>
>> -- 
>> As I’ve gotten older, people think I’ve become lazy.  The truth is I’m just being more energy efficient.
>>
Very well, then.  I thought I should mention it.

Thank you, and thanks to all contributors.

P

-- 
Excel continues to squat at the heart of business computing like a bowl of leeches in the ICU. -- Rupert Goodwins, 2020/10/06