From: "Peter Müller" <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: [RFC PATCH] backup: Set owner of /var/ipfire/backup/{in,ex}clude to "root"
Date: Thu, 15 Sep 2022 19:15:09 +0000 [thread overview]
Message-ID: <d0225ffd-d82d-ede0-87f1-9ca4fb879dd8@ipfire.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1708 bytes --]
Since these files are static, there is no legitimate reason why they
should be owned (hence writable) by "nobody".
Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
---
lfs/backup | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lfs/backup b/lfs/backup
index 6f686bf22..adbf16e65 100644
--- a/lfs/backup
+++ b/lfs/backup
@@ -1,7 +1,7 @@
###############################################################################
# #
# IPFire.org - A linux based firewall #
-# Copyright (C) 2007-2021 IPFire Team <info(a)ipfire.org> #
+# Copyright (C) 2007-2022 IPFire Team <info(a)ipfire.org> #
# #
# This program is free software: you can redistribute it and/or modify #
# it under the terms of the GNU General Public License as published by #
@@ -61,8 +61,8 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
@$(PREBUILD)
-mkdir -p /var/ipfire/backup/bin
install -v -m 755 -o root $(DIR_SRC)/config/backup/backup.pl /var/ipfire/backup/bin
- install -v -m 644 $(DIR_SRC)/config/backup/include /var/ipfire/backup/
- install -v -m 644 $(DIR_SRC)/config/backup/exclude /var/ipfire/backup/
+ install -v -m 644 -o root $(DIR_SRC)/config/backup/include /var/ipfire/backup/
+ install -v -m 644 -o root $(DIR_SRC)/config/backup/exclude /var/ipfire/backup/
chown nobody:nobody -R /var/ipfire/backup/
chown root:root -R /var/ipfire/backup/bin/
-mkdir -p /var/ipfire/backup/addons
--
2.35.3
next reply other threads:[~2022-09-15 19:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 19:15 Peter Müller [this message]
2022-09-16 8:27 ` [RFC PATCH] backup: Set owner of /var/ipfire/backup/{in, ex}clude " Michael Tremer
2022-09-17 10:17 ` Peter Müller
2022-09-18 9:17 ` Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0225ffd-d82d-ede0-87f1-9ca4fb879dd8@ipfire.org \
--to=peter.mueller@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox