public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] pakfire_format_time(): Fix typo
Date: Wed, 22 Mar 2023 17:38:44 +0100	[thread overview]
Message-ID: <d12c9268-8ab3-d98e-67a6-25049051d634@ipfire.org> (raw)
In-Reply-To: <20230321101413.1592037-1-stefan.schantl@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 954 bytes --]

Reviewed-by: Bernhard Bitsc <bbitsch(a)ipfire.org>

Am 21.03.2023 um 11:14 schrieb Stefan Schantl:
> Fix a small typo when displaying the build time
> which is longer than 1 hour.
> 
> In such a case the following message got displayed:
> 
> Build successfully completed in 01m07m02s
> 
> Which should be 01h07m02s
> 
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
>   src/libpakfire/string.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libpakfire/string.c b/src/libpakfire/string.c
> index 8eaf8d91..931ba701 100644
> --- a/src/libpakfire/string.c
> +++ b/src/libpakfire/string.c
> @@ -394,7 +394,7 @@ int __pakfire_format_time(char* buffer, const size_t length, const time_t t) {
>   	if (t >= 86400)
>   		format = "%dd%Hh%Mm";
>   	else if (t >= 3600)
> -		format = "%Hm%Mm%Ss";
> +		format = "%Hh%Mm%Ss";
>   	else if (t >= 60)
>   		format = "%Mm%Ss";
>   	else

      reply	other threads:[~2023-03-22 16:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-21 10:14 Stefan Schantl
2023-03-22 16:38 ` Bernhard Bitsch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d12c9268-8ab3-d98e-67a6-25049051d634@ipfire.org \
    --to=bbitsch@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox