From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter =?utf-8?q?M=C3=BCller?= <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 6/7] pakfire.cgi: Discard tac stderr output
Date: Sun, 08 May 2022 13:12:43 +0000
Message-ID: <d54a1505-03b7-8053-99fa-965842cfd780@ipfire.org>
In-Reply-To: <20220508120952.52-6-hofmann@leo-andres.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8891978271493335124=="
List-Id: <development.lists.ipfire.org>

--===============8891978271493335124==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Acked-by: Peter M=C3=BCller <peter.muelle(a)ipfire.org>

> Prevents meaningless "broken pipe" messages in the httpd error log.
>=20
> Signed-off-by: Leo-Andres Hofmann <hofmann(a)leo-andres.de>
> ---
>  html/cgi-bin/pakfire.cgi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/html/cgi-bin/pakfire.cgi b/html/cgi-bin/pakfire.cgi
> index 6fade81bd..489b07a6d 100644
> --- a/html/cgi-bin/pakfire.cgi
> +++ b/html/cgi-bin/pakfire.cgi
> @@ -75,7 +75,7 @@ if($cgiparams{'ACTION'} eq 'json-getstatus') {
> =20
>  	# Read /var/log/messages backwards until a "Pakfire started" header is fo=
und,
>  	# to capture all messages of the last (i.e. current) Pakfire run
> -	my @messages =3D `tac /var/log/messages | sed -n '/pakfire:/{p;/Pakfire.*=
started/q}'`;
> +	my @messages =3D `tac /var/log/messages 2>/dev/null | sed -n '/pakfire:/{=
p;/Pakfire.*started/q}'`;
> =20
>  	# Test if the log contains an error message (fastest implementation, stop=
s at first match)
>  	my $failure =3D any{ index($_, 'ERROR') !=3D -1 } @messages;

--===============8891978271493335124==--