From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter =?utf-8?q?M=C3=BCller?= To: development@lists.ipfire.org Subject: Re: [PATCH] dhcp.cgi: Add column with resolved hostname by IP address Date: Fri, 24 Nov 2023 13:21:00 +0000 Message-ID: In-Reply-To: <20231117144422.21685-1-sebastien.gislain@free.fr> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7300560924435682836==" List-Id: --===============7300560924435682836== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello Sebastien, and thank you for this patch. Looks good to me; it will land in Core Update 182. Keep these coming, appreciated! :-) Reviewed-by: Peter M=C3=BCller Thanks, and best regards, Peter M=C3=BCller > In web interface, on page DHCP Server, in table Current fixed leases, add c= olumn with resolved hostname by IP address > --- > html/cgi-bin/dhcp.cgi | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) >=20 > diff --git a/html/cgi-bin/dhcp.cgi b/html/cgi-bin/dhcp.cgi > index f45703f0b..b87da6907 100755 > --- a/html/cgi-bin/dhcp.cgi > +++ b/html/cgi-bin/dhcp.cgi > @@ -21,6 +21,7 @@ > =20 > use strict; > use experimental 'smartmatch'; > +use IO::Socket; > =20 > # enable only the following on debugging purpose > #use warnings; > @@ -1007,8 +1008,9 @@ END > print < > > - > - > + > + > + > > > > > + > > > --===============7300560924435682836==--
$Lang::tr{'mac address'}$Lang::tr{'ip address'}$Lang::tr{'mac address'}$Lang::tr{'ip address'}$Lang::tr{'hostname'}$Lang::tr{'remark'}next-serverfilename<= /th> > @@ -1106,9 +1108,14 @@ foreach my $line (@current2) { > $TAG4 =3D "class=3D'red'" if ($dhcpsettings{'KEY2'} ne $key); > } > =20 > + # resolved name (if exists) > + my $iaddr =3D inet_aton($temp[1]); > + my $rname =3D gethostbyaddr($iaddr, AF_INET); > + if (!$rname || $rname eq "") { $rname =3D $Lang::tr{'ptr lookup failed'};= } > print < $TAG2$temp[0]$TAG3$TAG0$temp[1]$TAG1$rname $temp[6] $temp[3] $temp[4]