From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.haj.ipfire.org (localhost [IPv6:::1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4cXYW61Y14z2y5k for ; Thu, 25 Sep 2025 12:51:30 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail01.haj.ipfire.org", Issuer "R13" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4cXYW25jHgz2xM3 for ; Thu, 25 Sep 2025 12:51:26 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4cXYW21n9rz2RM for ; Thu, 25 Sep 2025 12:51:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1758804686; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EJjzTq2OV4ogOPYN3JL6iRKblmJyCf8gQ0/EMzgOrdk=; b=rrmKfByQXKndRQ8UoCOI4mpHqPftWujOyqLj+YGNtAVA6HTti10fmxq8EsrMsMCGRobfRe x+TnlmOK9exzkgHxmrLNGc529gsqdEHe7zSKYVOF0puCUKDHKFZt4v61GjaFDyvKRDZidV FOxNjM+YLUuWoxCYL7eAWv4ERQRaintphYz5Lgnv94VYDro1rbR/fK94FcFxEfW/+eaFm5 fQKdsKCz9Cb/c/up7wfcYvi7HvUqzgRyRoHR88E/ToPmE9YnJpX6JodLIuEavm9nAMnJuj lU8yfFbVdx0MrsYxpGVb9FXEkyAfhdSg2ghwU1cLtEku9TtgPa9LOXtAVwRD8g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1758804686; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EJjzTq2OV4ogOPYN3JL6iRKblmJyCf8gQ0/EMzgOrdk=; b=nKg6Wdfufn+wokqhZ/sxd9ANJB+DNg2qg4hxOi6q6ba9gy8hu6L8ep25asXwPlefk9nR85 TmJyuGVnv/20fFAg== Message-ID: Date: Thu, 25 Sep 2025 14:51:25 +0200 Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: MIME-Version: 1.0 Subject: Re: [PATCH 02/16] ids.cgi: Fixes bug 13878 To: development@lists.ipfire.org References: <20250925111252.11893-1-adolf.belka@ipfire.org> <20250925111252.11893-2-adolf.belka@ipfire.org> Content-Language: en-GB From: Bernhard Bitsch In-Reply-To: <20250925111252.11893-2-adolf.belka@ipfire.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reviewed-by: Bernhard Bitsch Am 25.09.2025 um 13:12 schrieb Adolf Belka: > Fixes: bug 13878 - IGNORE_ENTRY_REMARK Stored Cross-Site Scripting > Signed-off-by: Adolf Belka > --- > html/cgi-bin/ids.cgi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/html/cgi-bin/ids.cgi b/html/cgi-bin/ids.cgi > index 994872564..9c6b393f6 100644 > --- a/html/cgi-bin/ids.cgi > +++ b/html/cgi-bin/ids.cgi > @@ -2,7 +2,7 @@ > ############################################################################### > # # > # IPFire.org - A linux based firewall # > -# Copyright (C) 2007-2020 IPFire Team # > +# Copyright (C) 2007-2025 IPFire Team # > # # > # This program is free software: you can redistribute it and/or modify # > # it under the terms of the GNU General Public License as published by # > @@ -105,7 +105,7 @@ if (($cgiparams{'WHITELIST'} eq $Lang::tr{'add'}) || ($cgiparams{'WHITELIST'} eq > > # Assign hash values. > my $new_entry_address = $cgiparams{'IGNORE_ENTRY_ADDRESS'}; > - my $new_entry_remark = $cgiparams{'IGNORE_ENTRY_REMARK'}; > + my $new_entry_remark = &Header::escape($cgiparams{'IGNORE_ENTRY_REMARK'}); > > # Read-in ignoredfile. > &General::readhasharray($IDS::ignored_file, \%ignored) if (-e $IDS::ignored_file);