From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Marx To: development@lists.ipfire.org Subject: Re: [PATCH] BUG12403: Fix permissions of DMA configfile Date: Mon, 11 May 2020 11:02:28 +0200 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5721191467743430811==" List-Id: --===============5721191467743430811== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Am 11.05.20 um 10:35 schrieb Michael Tremer: > Hello, > >> On 9 May 2020, at 07:06, Alexander Marx wrot= e: >> >> From: Alexander Marx > Your Git is set up with a different email address for commits than what you= are using for email. Is this intentional? There were some confusions when i set up the accounts in the beginning.... >> Change read permissions of dma configfile so other users are able to read = it. >> Needed for Addons like WIO to send Mails. > I am not sure if this patch is a good idea. We will make the credentials re= adable for everyone. > > What would probably work better is a group called =E2=80=9Cmail=E2=80=9D wh= ich nobody and wio will be a member of so that they can read the configuratio= n file. Others still won=E2=80=99t be able to read it. > > What do you think about this solution? > > Best, > -Michael Well, it's a bit more complex. The next thing i am working on with=20 Stephan will be the APCUPSD with a nice webinterface. To make things=20 round we are thinking of putting the apcupd and website together in one=20 addon. But the apcupsd has a complete different user (apcups) and maybe=20 there will be other tools and services with own usernames that also=20 could use the mailaddon. Therefor a general readpermission would be a good solution. In case of apcups we would otherwise be forced to put the apcups user=20 into the mailgroup. Anyway, if this is not the solution, please delete the patch and we try=20 to find another solution. Alex >> FIXES: #12403 >> --- >> lfs/dma | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/lfs/dma b/lfs/dma >> index aceb2704e..6b5d9bfbf 100644 >> --- a/lfs/dma >> +++ b/lfs/dma >> @@ -24,7 +24,7 @@ >> >> include Config >> >> -VER =3D 0.12 >> +VER =3D 0.13 >> >> THISAPP =3D dma-$(VER) >> DL_FILE =3D $(THISAPP).tar.gz >> @@ -80,6 +80,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) >> install -v -m 755 $(DIR_SRC)/config/dma/dma-cleanup-spool /usr/sbin >> chown -R nobody.nobody /var/ipfire/dma >> chown nobody.root /var/ipfire/dma/auth.conf >> + chmod 644 /var/ipfire/dma/auth.conf >> ln -svf dma /usr/sbin/sendmail.dma >> /usr/sbin/alternatives --install /usr/sbin/sendmail sendmail /usr/sbin/se= ndmail.dma 20 >> @rm -rf $(DIR_APP) >> --=20 >> 2.17.1 >> --===============5721191467743430811==--