public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Stefan Schantl <stefan.schantl@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] general-functions.pl: Only skip lines with a # at the beginning
Date: Mon, 18 Feb 2019 11:38:02 +0100	[thread overview]
Message-ID: <dab1baa2af5ab2c347a469f19f858b1335e86ff5.camel@ipfire.org> (raw)
In-Reply-To: <20190218102813.29248-1-michael.tremer@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 821 bytes --]

Hello Michael,

thanks for the patch and figuring out why the graphs are not displayed
anymore - merged!

Best regards,

-Stefan
> This accidientially dropped all lines that include #. That resulted
> in colour codes not being loaded from file any more.
> 
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
>  config/cfgroot/general-functions.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/config/cfgroot/general-functions.pl
> b/config/cfgroot/general-functions.pl
> index 2d3eb73d7..04e36969c 100644
> --- a/config/cfgroot/general-functions.pl
> +++ b/config/cfgroot/general-functions.pl
> @@ -151,7 +151,7 @@ sub readhash
>  		chop;
>  
>  		# Skip comments.
> -		next if ($_ =~ /\#/);
> +		next if ($_ =~ /^#/);
>  
>  		($var, $val) = split /=/, $_, 2;
>  		if ($var)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2019-02-18 10:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-18 10:28 Michael Tremer
2019-02-18 10:38 ` Stefan Schantl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dab1baa2af5ab2c347a469f19f858b1335e86ff5.camel@ipfire.org \
    --to=stefan.schantl@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox