* [PATCH] general-functions.pl: Only skip lines with a # at the beginning
@ 2019-02-18 10:28 Michael Tremer
2019-02-18 10:38 ` Stefan Schantl
0 siblings, 1 reply; 2+ messages in thread
From: Michael Tremer @ 2019-02-18 10:28 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 684 bytes --]
This accidientially dropped all lines that include #. That resulted
in colour codes not being loaded from file any more.
Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
---
config/cfgroot/general-functions.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/config/cfgroot/general-functions.pl b/config/cfgroot/general-functions.pl
index 2d3eb73d7..04e36969c 100644
--- a/config/cfgroot/general-functions.pl
+++ b/config/cfgroot/general-functions.pl
@@ -151,7 +151,7 @@ sub readhash
chop;
# Skip comments.
- next if ($_ =~ /\#/);
+ next if ($_ =~ /^#/);
($var, $val) = split /=/, $_, 2;
if ($var)
--
2.12.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] general-functions.pl: Only skip lines with a # at the beginning
2019-02-18 10:28 [PATCH] general-functions.pl: Only skip lines with a # at the beginning Michael Tremer
@ 2019-02-18 10:38 ` Stefan Schantl
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Schantl @ 2019-02-18 10:38 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 821 bytes --]
Hello Michael,
thanks for the patch and figuring out why the graphs are not displayed
anymore - merged!
Best regards,
-Stefan
> This accidientially dropped all lines that include #. That resulted
> in colour codes not being loaded from file any more.
>
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
> config/cfgroot/general-functions.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/config/cfgroot/general-functions.pl
> b/config/cfgroot/general-functions.pl
> index 2d3eb73d7..04e36969c 100644
> --- a/config/cfgroot/general-functions.pl
> +++ b/config/cfgroot/general-functions.pl
> @@ -151,7 +151,7 @@ sub readhash
> chop;
>
> # Skip comments.
> - next if ($_ =~ /\#/);
> + next if ($_ =~ /^#/);
>
> ($var, $val) = split /=/, $_, 2;
> if ($var)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-18 10:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-18 10:28 [PATCH] general-functions.pl: Only skip lines with a # at the beginning Michael Tremer
2019-02-18 10:38 ` Stefan Schantl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox