From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: Re: Testing of rapid_commit patch Date: Fri, 29 Nov 2024 20:04:27 +0100 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4625180603929509664==" List-Id: --===============4625180603929509664== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Michael, On 29/11/2024 15:10, Michael Tremer wrote: > Hello, >=20 > Thanks for testing this in production. Good to know this all works. >=20 >> On 29 Nov 2024, at 11:21, Adolf Belka wrote: >> >> Hi Michael, >> >> I had previously tested your rapid_commit patch on my vm network system. H= owever as that network does not have a problem with the rapid_commit option i= t was not the best test. >> >> I said that i would test it out on my production system after the visit to= my family. I have now got around to that. >> >> My new ISP, that bought out the very good technically based ISP I used to = have, is one of the ones that has a DHCP server that just times out if you ha= ve the rapid_commit option in the dhcpcd config file. >> >> So I updated my production IPFire to Core-Update 190 Development Build: ma= ster/1e2abd66 >> >> After rebooting the connection was lost as the rapid_commit option is on b= y default. >> >> I then ran the setup program and unchecked the rapid commit box on the red= interface and then rebooted and the connection was running. >> >> Another reboot still had the connection running. >> >> So I can confirm that the patch is working . >> >> The only thing that came to mind is when we do the update people who have = removed or commented out the rapid_commit option in dhcpcd.conf will lose the= ir connection. >> >> So either >> >> * we need to have the update check if the rapid_commit option has been com= mented out or has been removed and then disable the rapid commit option for t= he red interface. >> >> or >> >> * we need to make sure that it is well communicated that anyone who has di= sabled the rapid_commit option needs to run the setup program after the upgra= de (maybe before the reboot) to disable the option for the red interface. >=20 > If we wanted to be really fancy we could check if someone has modified the = configuration file and if so we can automatically set the setting in /var/ipf= ire/ethernet/settings. I am not sure how reliable this would be, but it is an= option. I could have a look at putting something together for this and test it=20 out on my vm system and then submit a patch for it, if that is fine with=20 you. Regards, Adolf. >=20 >> We can discuss this at our next conf call meeting on 3rd or 4th Dec. >=20 > We need to bring more things back to the list because there are currently o= nly so few people joining the call. I would also prefer to sort things out so= oner on the list if possible and keep the call as free as possible for more g= eneral discussion. >=20 > -Michael >=20 >> >> Regards, >> >> Adolf. >> >=20 --=20 Sent from my laptop --===============4625180603929509664==--