From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter =?utf-8?q?M=C3=BCller?= To: development@lists.ipfire.org Subject: Re: [PATCH] Core Update 165: Restart Squid during the update Date: Thu, 24 Mar 2022 09:15:01 +0000 Message-ID: In-Reply-To: <9D34E0D8-95F6-4970-9B1B-22317FFB4A71@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2438228995440465775==" List-Id: --===============2438228995440465775== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello Michael, hello Arne, > Hello, >=20 >> On 23 Mar 2022, at 09:34, Peter M=C3=BCller w= rote: >> >> Hello Adolf, >> hello Michael, >> >> thanks for your replies. >> >> Indeed, Core Update 165 does not contain a new version of Squid, and indee= d, there >> is bug #12623 for an issue where the proxy is not being started properly d= uring boot. >> I was unfortunately never able to reproduce this, or understand from the s= canty logs >> supplied what went wrong here. :-/ >=20 > Arne confirmed to me yesterday that he has seen the proxy not coming up pro= perly on a test system. Maybe he can help finding this? that would be great. On roughly a dozen of IPFire installations, all using th= e web proxy, I was never able to spot this. Therefore, I would be most interested in Arne's findings. Thanks, and best regards, Peter M=C3=BCller >=20 >> So, whatever went wrong on my testing machine with Squid and Core Update 1= 65, let's >> drop this patch - people are urged to reboot their IPFire installations as= soon as >> possible anyways. >> >> Thanks, and best regards, >> Peter M=C3=BCller >> >> >>> Hmm, okay. >>> >>> So when a service is being updated, it should be stopped before the updat= e is applied and restarted after the update is done. >>> >>> We usually do that - unless it is forgotten, which happens occasionally. = That should however not break anything. >>> >>> -Michael >>> >>>> On 21 Mar 2022, at 09:01, Adolf Belka wrote: >>>> >>>> Hi Peter, >>>> >>>> On 20/03/2022 19:32, Peter M=C3=BCller wrote: >>>>> Hello Michael, >>>>> >>>>> thanks for your reply. >>>>> >>>>> This is necessary because (a) we ship a new version of Squid with Core = Update 165 >>>>> and (b) not restarting Squid afterwards caused the web proxy to stall o= n my testing >>>>> machine. >>>> Following is for info. >>>> >>>> On my vm testbed I have all items running on the Services table and afte= r the CU to 165 they were all still running. >>>> I have never had a problem with the Web Proxy stopping running after any= Core Update. >>>> >>>> However there have been threads where people have reported occasionally = that there web proxy has stopped after a core update but usually a reboot res= olved that. >>>> >>>> Some people have reported, and I think there is still a bug open on this= , where the web proxy periodically stops working in normal operation and has = to be restarted or IPFire has to be rebooted to restart it. Unfortunately tho= se bug/thread originators have not usually provided logs or the logs provided= have not shown any issue. >>>> >>>> Regards, >>>> Adolf. >>>>> Thanks, and best regards, >>>>> Peter M=C3=BCller >>>>> >>>>> >>>>>> Why is this necessary? >>>>>> >>>>>>> On 20 Mar 2022, at 10:20, Peter M=C3=BCller wrote: >>>>>>> >>>>>>> Fixes: #12810 >>>>>>> >>>>>>> Signed-off-by: Peter M=C3=BCller >>>>>>> --- >>>>>>> config/rootfiles/core/165/update.sh | 1 + >>>>>>> 1 file changed, 1 insertion(+) >>>>>>> >>>>>>> diff --git a/config/rootfiles/core/165/update.sh b/config/rootfiles/c= ore/165/update.sh >>>>>>> index ffb552c80..2c2e6a10c 100644 >>>>>>> --- a/config/rootfiles/core/165/update.sh >>>>>>> +++ b/config/rootfiles/core/165/update.sh >>>>>>> @@ -128,6 +128,7 @@ ldconfig >>>>>>> # Start services >>>>>>> telinit u >>>>>>> /etc/rc.d/init.d/firewall restart >>>>>>> +/etc/rc.d/init.d/squid restart >>>>>>> >>>>>>> # Fix ownership of classification file. >>>>>>> chown nobody:nobody /usr/share/suricata/classification.config >>>>>>> --=20 >>>>>>> 2.34.1 >>>> >>>> --=20 >>>> Sent from my laptop >>> >=20 --===============2438228995440465775==--