[PATCH] qos.cgi: Removed last two P2P lines

[PATCH] qos.cgi: Removed last two P2P lines

[Matthias Fischer]

[-- Attachment #1: Type: text/plain, Size: 886 bytes --]

P2P "has left da house"...

Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
---
 html/cgi-bin/qos.cgi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/html/cgi-bin/qos.cgi b/html/cgi-bin/qos.cgi
index f3bbd1bf4..6d1c61638 100644
--- a/html/cgi-bin/qos.cgi
+++ b/html/cgi-bin/qos.cgi
@@ -474,13 +474,11 @@ imq0;200;1;$DOWN[20];$DOWN[1];;;8;VoIP;
 imq0;203;4;$DOWN[20];$DOWN[1];;;0;VPN;
 imq0;204;5;$DOWN[20];$DOWN[1];;;8;Webtraffic;
 imq0;210;6;1;$DOWN[1];;;0;Default;
-imq0;220;7;1;$DOWN[1];;;1;P2P;
 $qossettings{'RED_DEV'};101;1;$UP[10];$UP[1];;;8;ACKs;
 $qossettings{'RED_DEV'};102;2;$UP[10];$UP[1];;;8;VoIP;
 $qossettings{'RED_DEV'};103;4;$UP[10];$UP[1];;;2;VPN;
 $qossettings{'RED_DEV'};104;5;$UP[10];$UP[1];;;8;Webtraffic;
 $qossettings{'RED_DEV'};110;6;1;$UP[1];;;0;Default;
-$qossettings{'RED_DEV'};120;7;1;$UP[1];;;1;P2P;
 END
 ;
 		close FILE;
-- 
2.25.1

Re: [PATCH] qos.cgi: Removed last two P2P lines

[Peter Müller]

[-- Attachment #1: Type: text/plain, Size: 981 bytes --]

Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org>

> P2P "has left da house"...
> 
> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> ---
>  html/cgi-bin/qos.cgi | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/html/cgi-bin/qos.cgi b/html/cgi-bin/qos.cgi
> index f3bbd1bf4..6d1c61638 100644
> --- a/html/cgi-bin/qos.cgi
> +++ b/html/cgi-bin/qos.cgi
> @@ -474,13 +474,11 @@ imq0;200;1;$DOWN[20];$DOWN[1];;;8;VoIP;
>  imq0;203;4;$DOWN[20];$DOWN[1];;;0;VPN;
>  imq0;204;5;$DOWN[20];$DOWN[1];;;8;Webtraffic;
>  imq0;210;6;1;$DOWN[1];;;0;Default;
> -imq0;220;7;1;$DOWN[1];;;1;P2P;
>  $qossettings{'RED_DEV'};101;1;$UP[10];$UP[1];;;8;ACKs;
>  $qossettings{'RED_DEV'};102;2;$UP[10];$UP[1];;;8;VoIP;
>  $qossettings{'RED_DEV'};103;4;$UP[10];$UP[1];;;2;VPN;
>  $qossettings{'RED_DEV'};104;5;$UP[10];$UP[1];;;8;Webtraffic;
>  $qossettings{'RED_DEV'};110;6;1;$UP[1];;;0;Default;
> -$qossettings{'RED_DEV'};120;7;1;$UP[1];;;1;P2P;
>  END
>  ;
>  		close FILE;

Re: [PATCH] qos.cgi: Removed last two P2P lines

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1383 bytes --]

Hello Matthias,

Although this mentions the phrase “P2P”, this has nothing to do with the filter.

This creates a class which uses the l7 filter to match any P2P traffic and throttle it.

Please drop this patch as it would create an inconsistent QoS configuration since the rules in that class are not deleted.

-Michael

> On 3 Apr 2022, at 17:04, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
> 
> P2P "has left da house"...
> 
> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> ---
> html/cgi-bin/qos.cgi | 2 --
> 1 file changed, 2 deletions(-)
> 
> diff --git a/html/cgi-bin/qos.cgi b/html/cgi-bin/qos.cgi
> index f3bbd1bf4..6d1c61638 100644
> --- a/html/cgi-bin/qos.cgi
> +++ b/html/cgi-bin/qos.cgi
> @@ -474,13 +474,11 @@ imq0;200;1;$DOWN[20];$DOWN[1];;;8;VoIP;
> imq0;203;4;$DOWN[20];$DOWN[1];;;0;VPN;
> imq0;204;5;$DOWN[20];$DOWN[1];;;8;Webtraffic;
> imq0;210;6;1;$DOWN[1];;;0;Default;
> -imq0;220;7;1;$DOWN[1];;;1;P2P;
> $qossettings{'RED_DEV'};101;1;$UP[10];$UP[1];;;8;ACKs;
> $qossettings{'RED_DEV'};102;2;$UP[10];$UP[1];;;8;VoIP;
> $qossettings{'RED_DEV'};103;4;$UP[10];$UP[1];;;2;VPN;
> $qossettings{'RED_DEV'};104;5;$UP[10];$UP[1];;;8;Webtraffic;
> $qossettings{'RED_DEV'};110;6;1;$UP[1];;;0;Default;
> -$qossettings{'RED_DEV'};120;7;1;$UP[1];;;1;P2P;
> END
> ;
> 		close FILE;
> -- 
> 2.25.1
> 

Re: [PATCH] qos.cgi: Removed last two P2P lines

[Matthias Fischer]

[-- Attachment #1: Type: text/plain, Size: 1604 bytes --]

Hi,

On 04.04.2022 10:34, Michael Tremer wrote:
> Hello Matthias,
> 
> Although this mentions the phrase “P2P”, this has nothing to do with the filter.

Thats why I asked on the list, but didn't wait long enough. Doh!

> This creates a class which uses the l7 filter to match any P2P traffic and throttle it.
> 
> Please drop this patch as it would create an inconsistent QoS configuration since the rules in that class are not deleted.

Done.

Sorry for the noise.

Best,
Matthias

> -Michael
> 
>> On 3 Apr 2022, at 17:04, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
>> 
>> P2P "has left da house"...
>> 
>> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
>> ---
>> html/cgi-bin/qos.cgi | 2 --
>> 1 file changed, 2 deletions(-)
>> 
>> diff --git a/html/cgi-bin/qos.cgi b/html/cgi-bin/qos.cgi
>> index f3bbd1bf4..6d1c61638 100644
>> --- a/html/cgi-bin/qos.cgi
>> +++ b/html/cgi-bin/qos.cgi
>> @@ -474,13 +474,11 @@ imq0;200;1;$DOWN[20];$DOWN[1];;;8;VoIP;
>> imq0;203;4;$DOWN[20];$DOWN[1];;;0;VPN;
>> imq0;204;5;$DOWN[20];$DOWN[1];;;8;Webtraffic;
>> imq0;210;6;1;$DOWN[1];;;0;Default;
>> -imq0;220;7;1;$DOWN[1];;;1;P2P;
>> $qossettings{'RED_DEV'};101;1;$UP[10];$UP[1];;;8;ACKs;
>> $qossettings{'RED_DEV'};102;2;$UP[10];$UP[1];;;8;VoIP;
>> $qossettings{'RED_DEV'};103;4;$UP[10];$UP[1];;;2;VPN;
>> $qossettings{'RED_DEV'};104;5;$UP[10];$UP[1];;;8;Webtraffic;
>> $qossettings{'RED_DEV'};110;6;1;$UP[1];;;0;Default;
>> -$qossettings{'RED_DEV'};120;7;1;$UP[1];;;1;P2P;
>> END
>> ;
>> 		close FILE;
>> -- 
>> 2.25.1
>> 
>