From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matthias Fischer <matthias.fischer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] qos.cgi: Removed last two P2P lines
Date: Mon, 04 Apr 2022 18:15:50 +0200
Message-ID: <dc59b675-97a8-ee39-a96a-8a71c344528f@ipfire.org>
In-Reply-To: <C3EBEEE1-4663-478A-9744-55DD92F602E5@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4729627407259763601=="
List-Id: <development.lists.ipfire.org>

--===============4729627407259763601==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On 04.04.2022 10:34, Michael Tremer wrote:
> Hello Matthias,
>=20
> Although this mentions the phrase =E2=80=9CP2P=E2=80=9D, this has nothing t=
o do with the filter.

Thats why I asked on the list, but didn't wait long enough. Doh!

> This creates a class which uses the l7 filter to match any P2P traffic and =
throttle it.
>=20
> Please drop this patch as it would create an inconsistent QoS configuration=
 since the rules in that class are not deleted.

Done.

Sorry for the noise.

Best,
Matthias

> -Michael
>=20
>> On 3 Apr 2022, at 17:04, Matthias Fischer <matthias.fischer(a)ipfire.org> =
wrote:
>>=20
>> P2P "has left da house"...
>>=20
>> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
>> ---
>> html/cgi-bin/qos.cgi | 2 --
>> 1 file changed, 2 deletions(-)
>>=20
>> diff --git a/html/cgi-bin/qos.cgi b/html/cgi-bin/qos.cgi
>> index f3bbd1bf4..6d1c61638 100644
>> --- a/html/cgi-bin/qos.cgi
>> +++ b/html/cgi-bin/qos.cgi
>> @@ -474,13 +474,11 @@ imq0;200;1;$DOWN[20];$DOWN[1];;;8;VoIP;
>> imq0;203;4;$DOWN[20];$DOWN[1];;;0;VPN;
>> imq0;204;5;$DOWN[20];$DOWN[1];;;8;Webtraffic;
>> imq0;210;6;1;$DOWN[1];;;0;Default;
>> -imq0;220;7;1;$DOWN[1];;;1;P2P;
>> $qossettings{'RED_DEV'};101;1;$UP[10];$UP[1];;;8;ACKs;
>> $qossettings{'RED_DEV'};102;2;$UP[10];$UP[1];;;8;VoIP;
>> $qossettings{'RED_DEV'};103;4;$UP[10];$UP[1];;;2;VPN;
>> $qossettings{'RED_DEV'};104;5;$UP[10];$UP[1];;;8;Webtraffic;
>> $qossettings{'RED_DEV'};110;6;1;$UP[1];;;0;Default;
>> -$qossettings{'RED_DEV'};120;7;1;$UP[1];;;1;P2P;
>> END
>> ;
>> 		close FILE;
>> --=20
>> 2.25.1
>>=20
>=20


--===============4729627407259763601==--