public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: "Peter Müller" <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH 6/6] Icinga: Do not ship event handlers for Nagios
Date: Fri, 21 May 2021 15:42:36 +0200	[thread overview]
Message-ID: <dc792266-ca8e-eb86-90e1-281436c8b15e@ipfire.org> (raw)
In-Reply-To: <423afb1f-304d-eecf-8db3-3ea5d9353fb8@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1549 bytes --]

These are owned (hence being writable) by "nobody", posing a potential
security risk. Since the files itself were already exluded from being
shipped, their parent directory should be as well.

This patch should reduce the amount of executable files being owned by
nobody to zero after upgrading to Core Update 157. Due to complexity
reasons, not all applications available in Pakfire could be tested,
though, so your mileage may vary.

Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
---
 config/rootfiles/packages/icinga | 2 +-
 lfs/icinga                       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/config/rootfiles/packages/icinga b/config/rootfiles/packages/icinga
index f81ba9db2..000be6346 100644
--- a/config/rootfiles/packages/icinga
+++ b/config/rootfiles/packages/icinga
@@ -25,7 +25,7 @@ usr/bin/icinga
 usr/bin/icingastats
 #usr/lib/icinga
 usr/lib/icinga/p1.pl
-usr/lib/nagios/plugins/eventhandlers
+#usr/lib/nagios/plugins/eventhandlers
 #usr/lib/nagios/plugins/eventhandlers/disable_active_service_checks
 #usr/lib/nagios/plugins/eventhandlers/disable_notifications
 #usr/lib/nagios/plugins/eventhandlers/distributed-monitoring
diff --git a/lfs/icinga b/lfs/icinga
index 6534722ac..456f66388 100644
--- a/lfs/icinga
+++ b/lfs/icinga
@@ -32,7 +32,7 @@ DL_FROM    = $(URL_IPFIRE)
 DIR_APP    = $(DIR_SRC)/$(THISAPP)
 TARGET     = $(DIR_INFO)/$(THISAPP)
 PROG       = icinga
-PAK_VER    = 4
+PAK_VER    = 5
 
 DEPS       = nagios-plugins
 
-- 
2.26.2

      reply	other threads:[~2021-05-21 13:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-21 13:40 [PATCH 0/6] Patchset for fixing errors surfaced in Core Update 157 (testing) Peter Müller
2021-05-21 13:40 ` [PATCH 1/6] Core Update 157: Apply changed SSH configurations Peter Müller
2021-05-21 13:41   ` [PATCH 2/6] Core Update 157: Ship backup package to apply changed permissions Peter Müller
2021-05-21 13:41     ` [PATCH 3/6] pppd: Explicitly ship pppd shared object files Peter Müller
2021-05-21 13:41       ` [PATCH 4/6] Core Update 157: Delete shared object files leftover from pppd 2.4.8 Peter Müller
2021-05-21 13:42         ` [PATCH 5/6] nagios-plugins: Set SUID bit for plugins which need it to function properly Peter Müller
2021-05-21 13:42           ` Peter Müller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc792266-ca8e-eb86-90e1-281436c8b15e@ipfire.org \
    --to=peter.mueller@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox