From: Adolf Belka <ahb.ipfire@gmail.com>
To: development@lists.ipfire.org
Subject: Re: [PATCH] strongswan: Update to 5.9.0
Date: Wed, 02 Sep 2020 15:52:46 +0200 [thread overview]
Message-ID: <de1115c7-1291-4be6-5a56-3a675813db5c@gmail.com> (raw)
In-Reply-To: <F441EB0F-3DE2-4AF0-9980-598C862DF86F@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 2182 bytes --]
Hi Michael,
Sorry for the error with the email address. Yes that was finger trouble. The first @ should have been a .
Unfortunately I then copy/pasted that into the postfix patch, so that has the same error.
Didn't know about the "git commit -s" option. Will remember that for the future.
Regarding the rootfiles, I must admit I didn't look at them, for strongswan or postfix, because the build didn't highlight that there was a difference that needed to be resolved. I had assumed that if the build didn't highlight anything then the rootfiles were the same.
For future builds I will explicitly check if there is any difference in the rootfiles.
I will also go back and check for strongswan and postfix and report back if there is any difference requiring me to redo the patches.
Regards,
Adolf
On 02/09/2020 15:29, Michael Tremer wrote:
> Hi,
>
>> On 2 Sep 2020, at 09:36, Adolf Belka <ahb.ipfire(a)gmail.com> wrote:
>>
>> - Update strongswan from version 5.8.4 to 5.9.0
>> see https://wiki.strongswan.org/versions/78
>>
>> Supporting request from Peter Müller
>> Signed-off-by: Adolf Belka<ahb(a)ipfire@gmail.com
> This is a slightly invalid email address.
>
> You can simply run “git commit -s” and it will automatically add that line for you, so that you don’t have to worry about it any more.
>
> Apart from that, the patch looks good. Did you check for any rootfile changes?
>
> Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
>
> Best,
> -Michael
>
>> ---
>> lfs/strongswan | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/lfs/strongswan b/lfs/strongswan
>> index 3be90db9a..d62a37c81 100644
>> --- a/lfs/strongswan
>> +++ b/lfs/strongswan
>> @@ -24,7 +24,7 @@
>>
>> include Config
>>
>> -VER = 5.8.4
>> +VER = 5.9.0
>>
>> THISAPP = strongswan-$(VER)
>> DL_FILE = $(THISAPP).tar.bz2
>> @@ -40,7 +40,7 @@ objects = $(DL_FILE)
>>
>> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
>>
>> -$(DL_FILE)_MD5 = 0634e7f40591bd3f6770e583c3f27d29
>> +$(DL_FILE)_MD5 = 705628cddd5b7683ef8a688acd9514d8
>>
>> install : $(TARGET)
>>
>> --
>> 2.28.0
>>
next prev parent reply other threads:[~2020-09-02 13:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 8:36 Adolf Belka
2020-09-02 13:29 ` Michael Tremer
2020-09-02 13:52 ` Adolf Belka [this message]
2020-09-02 21:35 ` Adolf Belka
2020-09-04 15:47 ` Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de1115c7-1291-4be6-5a56-3a675813db5c@gmail.com \
--to=ahb.ipfire@gmail.com \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox