From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adolf Belka <ahb.ipfire@gmail.com>
To: development@lists.ipfire.org
Subject: Re: [PATCH] strongswan: Update to 5.9.0
Date: Wed, 02 Sep 2020 15:52:46 +0200
Message-ID: <de1115c7-1291-4be6-5a56-3a675813db5c@gmail.com>
In-Reply-To: <F441EB0F-3DE2-4AF0-9980-598C862DF86F@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1235295592205100895=="
List-Id: <development.lists.ipfire.org>

--===============1235295592205100895==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Michael,

Sorry for the error with the email address. Yes that was finger trouble. The =
first @ should have been a .

Unfortunately I then copy/pasted that into the postfix patch, so that has the=
 same error.

Didn't know about the "git commit -s" option. Will remember that for the futu=
re.


Regarding the rootfiles, I must admit I didn't look at them, for strongswan o=
r postfix, because the build didn't highlight that there was a difference tha=
t needed to be resolved. I had assumed that if the build didn't highlight any=
thing then the rootfiles were the same.

For future builds I will explicitly check if there is any difference in the r=
ootfiles.

I will also go back and check for strongswan and postfix and report back if t=
here is any difference requiring me to redo the patches.

Regards,

Adolf

On 02/09/2020 15:29, Michael Tremer wrote:
> Hi,
>
>> On 2 Sep 2020, at 09:36, Adolf Belka <ahb.ipfire(a)gmail.com> wrote:
>>
>> - Update strongswan from version 5.8.4 to 5.9.0
>>   see https://wiki.strongswan.org/versions/78
>>
>> Supporting request from Peter M=C3=BCller
>> Signed-off-by: Adolf Belka<ahb(a)ipfire@gmail.com
> This is a slightly invalid email address.
>
> You can simply run =E2=80=9Cgit commit -s=E2=80=9D and it will automaticall=
y add that line for you, so that you don=E2=80=99t have to worry about it any=
 more.
>
> Apart from that, the patch looks good. Did you check for any rootfile chang=
es?
>
> Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
>
> Best,
> -Michael
>
>> ---
>> lfs/strongswan | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/lfs/strongswan b/lfs/strongswan
>> index 3be90db9a..d62a37c81 100644
>> --- a/lfs/strongswan
>> +++ b/lfs/strongswan
>> @@ -24,7 +24,7 @@
>>
>> include Config
>>
>> -VER        =3D 5.8.4
>> +VER        =3D 5.9.0
>>
>> THISAPP    =3D strongswan-$(VER)
>> DL_FILE    =3D $(THISAPP).tar.bz2
>> @@ -40,7 +40,7 @@ objects =3D $(DL_FILE)
>>
>> $(DL_FILE) =3D $(DL_FROM)/$(DL_FILE)
>>
>> -$(DL_FILE)_MD5 =3D 0634e7f40591bd3f6770e583c3f27d29
>> +$(DL_FILE)_MD5 =3D 705628cddd5b7683ef8a688acd9514d8
>>
>> install : $(TARGET)
>>
>> --=20
>> 2.28.0
>>

--===============1235295592205100895==--