public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: alf@i100.no
To: development@lists.ipfire.org
Subject: [PATCH] dracut: Update to 056
Date: Sat, 05 Mar 2022 10:00:11 +0100	[thread overview]
Message-ID: <df4611c24baa42f294d13be0f7ef55e4@i100.no> (raw)

[-- Attachment #1: Type: text/plain, Size: 1310 bytes --]

Hi

Regarding the patching of the "mdraid" code, 
modules.d/90mdraid/parse-md.sh, to reduce the code amount maintained in 
ipfire,
would it be an idea to rather patch this part of the original dracut 
code

if { [ -z "$MD_UUID" ] && ! getargbool 0 rd.auto; } || ! getargbool 1 
rd.md -d -n rd_NO_MD; then
     info "rd.md=0: removing MD RAID activation"
     udevproperty rd_NO_MD=1
else
     # rewrite the md rules to only process the specified raid array


I.e. to rather patch it to
if false; then
     info "rd.md=0: removing MD RAID activation"
     udevproperty rd_NO_MD=1
else
     # rewrite the md rules to only process the specified raid array


That would save about 25 lines of patch code that needs to be 
maintained, and you would just have one simple line of patch to 
maintain.


Or is the rationale that if dracut ever changes the code related to 
mdraid, you want your patch to run into conflict,
so you get a hint that you need to put some extra testing effort into 
systems with mdraid ?

I also read the dracut documentation, to try to understand if you could 
rather send in some of the parameters that it checks, as part of the 
dracut invocation,
but was unable to figure it out. To me, it seems like these parameters 
are picked up from the kernel command line from boot.


Regards
Alf

             reply	other threads:[~2022-03-05  9:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-05  9:00 alf [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-03-05 22:13 alf
2022-03-05 23:12 ` alf
2022-03-05  7:49 alf
2022-03-03 21:22 Peter Müller
2022-03-04 11:18 ` Michael Tremer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df4611c24baa42f294d13be0f7ef55e4@i100.no \
    --to=alf@i100.no \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox