From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 2/3] openvpn-authenticator: Drop some dead code
Date: Wed, 07 Dec 2022 13:22:21 +0100 [thread overview]
Message-ID: <df7184e9-61df-19e9-8c9c-4c4161981488@ipfire.org> (raw)
In-Reply-To: <20221206100144.4150532-2-michael.tremer@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1054 bytes --]
Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
On 06/12/2022 11:01, Michael Tremer wrote:
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
> config/ovpn/openvpn-authenticator | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/config/ovpn/openvpn-authenticator b/config/ovpn/openvpn-authenticator
> index 5d9348d7e..c22e08f0a 100644
> --- a/config/ovpn/openvpn-authenticator
> +++ b/config/ovpn/openvpn-authenticator
> @@ -97,18 +97,6 @@ class OpenVPNAuthenticator(object):
> # Send the command
> self._write_line(command)
>
> - return # XXX Code below doesn't work
> -
> - # Read response
> - response = self._read_line()
> -
> - # Handle response
> - if not response.startswith("SUCCESS:"):
> - log.error("Command '%s' returned an error:" % command)
> - log.error(" %s" % response)
> -
> - return response
> -
> def run(self):
> # Connect to socket
> self.sock = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
--
Sent from my laptop
next prev parent reply other threads:[~2022-12-07 12:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 10:01 [PATCH 1/3] openvpn-authenticator: Avoid infinite loop when losing socket connection Michael Tremer
2022-12-06 10:01 ` [PATCH 2/3] openvpn-authenticator: Drop some dead code Michael Tremer
2022-12-07 12:22 ` Adolf Belka [this message]
2022-12-06 10:01 ` [PATCH 3/3] openvpn-authenticator: Break read loop when daemon goes away Michael Tremer
2022-12-07 12:22 ` Adolf Belka
2022-12-07 12:21 ` [PATCH 1/3] openvpn-authenticator: Avoid infinite loop when losing socket connection Adolf Belka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df7184e9-61df-19e9-8c9c-4c4161981488@ipfire.org \
--to=adolf.belka@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox