From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 2/3] openvpn-authenticator: Drop some dead code
Date: Wed, 07 Dec 2022 13:22:21 +0100
Message-ID: <df7184e9-61df-19e9-8c9c-4c4161981488@ipfire.org>
In-Reply-To: <20221206100144.4150532-2-michael.tremer@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5777972148993768672=="
List-Id: <development.lists.ipfire.org>

--===============5777972148993768672==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>

On 06/12/2022 11:01, Michael Tremer wrote:
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
>   config/ovpn/openvpn-authenticator | 12 ------------
>   1 file changed, 12 deletions(-)
>
> diff --git a/config/ovpn/openvpn-authenticator b/config/ovpn/openvpn-authen=
ticator
> index 5d9348d7e..c22e08f0a 100644
> --- a/config/ovpn/openvpn-authenticator
> +++ b/config/ovpn/openvpn-authenticator
> @@ -97,18 +97,6 @@ class OpenVPNAuthenticator(object):
>   		# Send the command
>   		self._write_line(command)
>  =20
> -		return # XXX Code below doesn't work
> -
> -		# Read response
> -		response =3D self._read_line()
> -
> -		# Handle response
> -		if not response.startswith("SUCCESS:"):
> -			log.error("Command '%s' returned an error:" % command)
> -			log.error("  %s" % response)
> -
> -			return response
> -
>   	def run(self):
>   		# Connect to socket
>   		self.sock =3D socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)

--=20
Sent from my laptop


--===============5777972148993768672==--