Re: Feedback on Core Update 154 testing

["Adolf Belka (ipfire-dev)" <adolf.belka@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1292 bytes --]

Hi All,

I confirm that the problem of the curly bracket raised below is now fixed in the latest version of Core Update 154.

I have also tested Core Update 154 out in my VM Testbed and have gone through every menu item and checked everything out that I can. The things I could not test were IPsec Tunnel, URL Filter, Update Accelerator, Captive Portal.

All the rest I have been able to turn something on and set things and see if there were any problems. It is not a really deep testing of the menu items but I didn't find any issues at that level.

Regards,

Adolf.


On 16/02/2021 13:59, Adolf Belka (ipfire-dev) wrote:
> Hi All,
>
> After working on a new bug (#10628), my code was not working as I expected it to. After investigating I realised that when I provided https://patchwork.ipfire.org/patch/3724/ to add Deny Known Client capability to dhcp.cgi I had placed a curly bracket in the wrong place.
>
> It is not syntactically wrong so there is no Internal Error message coming up but if the Deny Known Clients is not checked then there is no check made for a valid Default Lease Time.
>
>
> I made an error when I inserted my code into dhcp.cgi for the Deny Known Clients fix.
>
>
> I will raise a patch to correct this.
>
>
> Regards,
>
> Adolf.
>