From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: Re: [PATCH] perl-Encode-Locale: New module dependency for LWP::UserAgent Date: Sat, 18 Jun 2022 11:33:51 +0200 Message-ID: In-Reply-To: <18175eea8c0.2777.cac9d3ffac9e24d09d20af05166fd73b@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5684898093830033525==" List-Id: --===============5684898093830033525== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Stefan, Rob and all, On 18/06/2022 10:29, Stefan Schantl wrote: > Hello Adolf, >=20 > thanks for working on this and sending your patch. >=20 > Everything looks good except the rootfile. When adding new perl modulles=20 > they are some kind of special and must=C2=A0 not contain any=C2=A0 architec= ture=20 > specific directory names. >=20 > These needs to=C2=A0 be replaced by a "xxxMACHINExxx". Duuuh. I know that but still managed to miss it. My only excuse is that I was=20 on vacation for 2 weeks and did not work on any patches so forgot about=20 that or didn't even see the architecture specific bits in the rootfile=20 lines. :-) :-) I do have a question now about this patch. The need for it was triggered=20 by an email from Rob. I had thought that he had identified error=20 messages about the missing Encode::Locale for LWP::UserAgent in core=20 parts of IPFire. However i see now from this message from Rob https://lists.ipfire.org/pipermail/development/2022-June/013691.html that it was identified from a personal add-on that he runs to generate=20 ADSL graphs. In IPFire LWP::UserAgent is used for the IDS core package and for the=20 Proxy Accounting add-on. I have both activated in my IPFire systems and=20 checking the logs there are no entries at all related to Encode, encode,=20 Locale or locale. So it looks like for IPFire its use of UserAgent.pm=20 does not need the Encode/Locale.pm module. My feeling would therefore be that Encode::Locale should not be=20 installed into the core package set unless my comments about=20 UserAgent.pm use in IPFire has a fault in it. Rob could make an additional personal add-on for Encode::Locale so his=20 ADSL data graphing add-on continues to work. It doesn't seem correct to add another package into the core IPFire set=20 that won't be used by nearly all IPFire systems. Feedback welcome, especially if I have misunderstood or missed anything. Regards, Adolf. >=20 > For more details see:=20 > https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dblob;f=3Dconfig/rootfiles/co= mmon/perl-HTTP-Date;h=3D75c250b7bad745eb70cec3115e79e24d231d69c1;hb=3DHEAD=20 > >=20 > Best regards, >=20 > -Stefan >=20 > Am 17. Juni 2022 22:50:45 schrieb Adolf Belka : >=20 >> - UserAgent.pm now has a dependency on Encode/Locale.pm >> - lfs and rootfile created >> - Module added to make.sh >> >> Signed-off-by: Adolf Belka >> --- >> =C2=A0config/rootfiles/common/perl-Encode-Locale | =C2=A06 ++ >> =C2=A0lfs/perl-Encode-Locale =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 | 79 ++++++++++++++++++++++ >> =C2=A0make.sh =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A01 + >> =C2=A03 files changed, 86 insertions(+) >> =C2=A0create mode 100644 config/rootfiles/common/perl-Encode-Locale >> =C2=A0create mode 100644 lfs/perl-Encode-Locale >> >> diff --git a/config/rootfiles/common/perl-Encode-Locale=20 >> b/config/rootfiles/common/perl-Encode-Locale >> new file mode 100644 >> index 000000000..b3c4d8fb7 >> --- /dev/null >> +++ b/config/rootfiles/common/perl-Encode-Locale >> @@ -0,0 +1,6 @@ >> +#usr/lib/perl5/site_perl/5.32.1/Encode >> +usr/lib/perl5/site_perl/5.32.1/Encode/Locale.pm >> +#usr/lib/perl5/site_perl/5.32.1/x86_64-linux-thread-multi/auto/Encode >> +#usr/lib/perl5/site_perl/5.32.1/x86_64-linux-thread-multi/auto/Encode/Loc= ale >> +#usr/lib/perl5/site_perl/5.32.1/x86_64-linux-thread-multi/auto/Encode/Loc= ale/.packlist >> +#usr/share/man/man3/Encode::Locale.3 >> diff --git a/lfs/perl-Encode-Locale b/lfs/perl-Encode-Locale >> new file mode 100644 >> index 000000000..a51208971 >> --- /dev/null >> +++ b/lfs/perl-Encode-Locale >> @@ -0,0 +1,79 @@ >> +#########################################################################= ###### >> +# =20 >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 # >> +# IPFire.org - A linux based firewall =20 >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 # >> +# Copyright (C) 2007-2019 =C2=A0IPFire Team =C2=A0 = =20 >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 # >> +# =20 >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 # >> +# This program is free software: you can redistribute it and/or=20 >> modify =C2=A0 =C2=A0 =C2=A0 =C2=A0# >> +# it under the terms of the GNU General Public License as published=20 >> by =C2=A0 =C2=A0 =C2=A0 =C2=A0# >> +# the Free Software Foundation, either version 3 of the License, or =20 >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 # >> +# (at your option) any later version. =20 >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 # >> +# =20 >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 # >> +# This program is distributed in the hope that it will be useful, =20 >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 # >> +# but WITHOUT ANY WARRANTY; without even the implied warranty of =20 >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0# >> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. =C2=A0See the = =20 >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 # >> +# GNU General Public License for more details. =20 >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0# >> +# =20 >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 # >> +# You should have received a copy of the GNU General Public License =20 >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 # >> +# along with this program. =C2=A0If not, see=20 >> . =C2=A0 =C2=A0 =C2=A0 # >> +# =20 >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 # >> +#########################################################################= ###### >> + >> + >> +#########################################################################= ###### >> +# Definitions >> +#########################################################################= ###### >> +include Config >> +VER =C2=A0 =C2=A0 =C2=A0 =C2=A0=3D 1.05 >> + >> +THISAPP =C2=A0 =C2=A0=3D Encode-Locale-$(VER) >> +DL_FILE =C2=A0 =C2=A0=3D ${THISAPP}.tar.gz >> +DL_FROM =C2=A0 =C2=A0=3D $(URL_IPFIRE) >> +DIR_APP =C2=A0 =C2=A0=3D $(DIR_SRC)/$(THISAPP) >> +TARGET =C2=A0 =C2=A0 =3D $(DIR_INFO)/$(THISAPP) >> + >> +#########################################################################= ###### >> +# Top-level Rules >> +#########################################################################= ###### >> + >> +objects =3D $(DL_FILE) >> + >> +$(DL_FILE) =3D $(DL_FROM)/$(DL_FILE) >> + >> +$(DL_FILE)_BLAKE2 =3D=20 >> f66bac8ebf012e7673b344b3899bed755558b80833a68b009b6083aeadd9d69748a63bee4e= 5e3c20dffaf7f2551fd6c9c778273ae992752c426e081d35715dee >> + >> +install : $(TARGET) >> + >> +check : $(patsubst %,$(DIR_CHK)/%,$(objects)) >> + >> +download :$(patsubst %,$(DIR_DL)/%,$(objects)) >> + >> +b2 : $(subst %,%_BLAKE2,$(objects)) >> + >> +dist: >> + @$(PAK) >> + >> +#########################################################################= ###### >> +# Downloading, checking, b2sum >> +#########################################################################= ###### >> + >> +$(patsubst %,$(DIR_CHK)/%,$(objects)) : >> + @$(CHECK) >> + >> +$(patsubst %,$(DIR_DL)/%,$(objects)) : >> + @$(LOAD) >> + >> +$(subst %,%_BLAKE2,$(objects)) : >> + @$(B2SUM) >> + >> +#########################################################################= ###### >> +# Installation Details >> +#########################################################################= ###### >> + >> +$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) >> + @$(PREBUILD) >> + @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar zxf $(DIR_DL)/$(DL_FILE) >> + cd $(DIR_APP) && perl Makefile.PL >> + cd $(DIR_APP) && make $(MAKETUNING) $(EXTRA_MAKE) >> + cd $(DIR_APP) && make install >> + @rm -rf $(DIR_APP) >> + @$(POSTBUILD) >> diff --git a/make.sh b/make.sh >> index 2a4f6d0bd..dd84cdc99 100755 >> --- a/make.sh >> +++ b/make.sh >> @@ -1373,6 +1373,7 @@ buildipfire() { >> =C2=A0 =C2=A0lfsmake2 perl-Digest >> =C2=A0 =C2=A0lfsmake2 perl-Digest-SHA1 >> =C2=A0 =C2=A0lfsmake2 perl-Digest-HMAC >> + =C2=A0lfsmake2 perl-Encode-Locale >> =C2=A0 =C2=A0lfsmake2 perl-libwww >> =C2=A0 =C2=A0lfsmake2 perl-LWP-Protocol-https >> =C2=A0 =C2=A0lfsmake2 perl-Net-HTTP >> --=20 >> 2.36.1 >=20 --=20 Sent from my laptop --===============5684898093830033525==--